Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premake: migrate to Conan v2 #18844

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Fails with

premake5: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by premake5)

for v1 in CI during test_package.
@AbrilRBS AbrilRBS self-assigned this Nov 21, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Nov 29, 2023

@RubenRBS Ping. I think this one is worth prioritizing for a review due to being a build tool as well as a dependency for a couple of other migrations.

recipes/premake/5.x/conandata.yml Outdated Show resolved Hide resolved
Comment on lines 58 to 60
if conan_version.major == 1 and self.settings.build_type == "Debug":
# https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/18844/15-linux-clang/premake/5.0.0-alpha15/summary.json
raise ConanInvalidConfiguration("Debug build not supported with Conan 1.x")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this fails. Also, why does it fail in conan 1 and not in conan 2? Also, please don't use that link for the logs, it could disappear at any time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce this locally and I suppose it might be possible to reproduce it in a container, but the Debug + Conan v1 combination is too niche to be worth the effort, IMO.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 17 (6f8793f67f62a55148dbeb40ba8bdb85f20cbc79):

  • premake/5.0.0-alpha15:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 17 (6f8793f67f62a55148dbeb40ba8bdb85f20cbc79):

  • premake/5.0.0-alpha15:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8ecce87 into conan-io:master Dec 14, 2023
13 checks passed
hoyhoy pushed a commit to hoyhoy/conan-center-index that referenced this pull request Dec 18, 2023
* premake: migrate to Conan v2

* premake: add VS 2022 support, fix package_type

* premake: fix Linux package()

* premake: fix package()

* premake: get rid of vs_ide_version use

* premake: add 5.0.0-beta2

* premake: add libuuid dependency

* premake: add layout to test_package

* premake: disable beta2

Fails with

premake5: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by premake5)

for v1 in CI during test_package.

* premake: workaround for Conan v1 debug build failure

* premake: tweak comments
valgur added a commit to valgur/conan-center-index that referenced this pull request Jan 1, 2024
* premake: migrate to Conan v2

* premake: add VS 2022 support, fix package_type

* premake: fix Linux package()

* premake: fix package()

* premake: get rid of vs_ide_version use

* premake: add 5.0.0-beta2

* premake: add libuuid dependency

* premake: add layout to test_package

* premake: disable beta2

Fails with

premake5: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by premake5)
premake5: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by premake5)

for v1 in CI during test_package.

* premake: workaround for Conan v1 debug build failure

* premake: tweak comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants