-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add version 1.83.0 #19175
boost: add version 1.83.0 #19175
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
I suggest to split the PR in 2, one the 1.83.0 upgrade, the other one for old version removal. I guess you will have less troubles. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3d2572eboost/1.83.0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff got a bit crazy, but this looks good! It's ok if you prefer splitting as @fpelliccioni suggests, but it's also fine by me it this stays as-is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing it, let's keep the old boost versions around for a while still. It's one of those libraries that people pin for long streches of time :)
@fpelliccioni @RubenRBS |
This comment has been minimized.
This comment has been minimized.
I managed to miss this PR and opened a semi-duplicate one #19251, sorry. You can ignore the version bump aspect of my PR and merge this one first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is identical to the one for 1.82.0. Why not simply reuse that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valgur
You are right!
Thank you for your review.
I fixed.
- zlib | ||
- zstd | ||
locale: | ||
- iconv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebuild-dependencies.py
drops the iconv
requirement. I'm not familiar enough with Boost and this recipe to say whether that's a valid change or not, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valgur
I think iconv requirement is still necessary.
Boost.Locale has the options to switch backend library.
"i18n_backend": ["iconv", "icu", None, "deprecated"],
"i18n_backend_iconv": ["libc", "libiconv", "off"],
"i18n_backend_icu": [True, False],
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Hooks produced the following warnings for commit 284ac8cboost/1.83.0@#f0c3932db7f65b606ed78357ecbdcbef
|
* boost: add version 1.83.0, remove older versions * revert 1.71.0, 1.72.0 * use 1.82.0's patch for 1.83.0
Specify library name and version: boost/*