Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structopt: update magic_enum/0.9.5 #21207

Closed
wants to merge 1 commit into from

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 18, 2023

Specify library name and version: structopt/*

magic_enum/0.9.5 changed include path from "magic_enum.hpp" to magic_enum/magic_enum.hpp.


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (78856dafc89ddf8e688958968a4e660c88a3b33d):

  • structopt/0.1.3:
    All packages built successfully! (All logs)

  • structopt/0.1.2:
    All packages built successfully! (All logs)

  • structopt/0.1.0:
    All packages built successfully! (All logs)

  • structopt/0.1.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (78856dafc89ddf8e688958968a4e660c88a3b33d):

  • structopt/0.1.3:
    All packages built successfully! (All logs)

  • structopt/0.1.0:
    All packages built successfully! (All logs)

  • structopt/0.1.1:
    All packages built successfully! (All logs)

  • structopt/0.1.2:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Nov 20, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for Ruben review

@uilianries
Copy link
Member

I just pushed a PR to the upstream: p-ranav/structopt#24

It should fix the current state by using patches.

@AbrilRBS
Copy link
Member

If the upstream PR does not get merged after this goes stale, we'll merge here as-is. The library seems not to be getting too many updates lately so they might take a bit

@toge
Copy link
Contributor Author

toge commented Aug 12, 2024

It is not necessary modification.
Please refer #24894

@toge toge closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants