-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brunsli: allow shared brotli dependency #21238
base: master
Are you sure you want to change the base?
Conversation
fefc579
to
c5d7afc
Compare
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
What was the reasoning behind disabling shared builds in the first place? has anything changed in the meantime? Upstream I do see references to brotli being used in static variants, so I'm a bit confused, would appreciate extra insight, thanks! :) |
The project itself hard-codes the builds to be static, but I patched around that in the original PR and forgot to re-enable it in the recipe. |
@RubenRBS Ping. |
My main fear with this is that we could become maintainers of "using shared brotli" if upstream does not really wants to support that - I'm initially in favour, but let me quickly double check with the team, sorry for the delay! |
No description provided.