Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incbin: allow msvc + pack incbin_tool on msvc #21488

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tomas-krupa
Copy link
Contributor

Specify library name and version: incbin/cci.20211107

  • enabled MSVC target
  • building and packing incbin_tool which is necessary to generate "included" binaries on MSVC build system
  • test_package serves also as example of using the poor-documented incbin_tool

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tomas-krupa
❌ tkrupa
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 7 (c6b725d14069331426187064956b260f66adf60b):

  • incbin/cci.20211107:
    CI failed to create some packages (All logs)

    Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    
    [...]
    -- This project seems to be plain C, using 'GNU' compiler
    -- Conan: Compiler GCC>=5, checking major version 5
    -- Conan: Checking correct version: 5
    -- Conan: C++ stdlib: libstdc++11
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v1/bsr/cci-ff0c1eb6/recipes/incbin/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8
    
    ----Running------
    > cmake --build '/home/conan/w/prod-v1/bsr/cci-ff0c1eb6/recipes/incbin/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building C object test_package/CMakeFiles/test_package.dir/test_package.c.o
    test_package/CMakeFiles/test_package.dir/build.make:81: recipe for target 'test_package/CMakeFiles/test_package.dir/test_package.c.o' failed
    CMakeFiles/Makefile2:112: recipe for target 'test_package/CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    /tmp/ccibWEqX.s: Assembler messages:
    /tmp/ccibWEqX.s:8: Error: file not found: CMakeLists.txt
    make[2]: *** [test_package/CMakeFiles/test_package.dir/test_package.c.o] Error 1
    make[1]: *** [test_package/CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    incbin/cci.20211107 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    incbin/cci.20211107 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    incbin/cci.20211107 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
    ERROR: incbin/cci.20211107 (test package): Error in build() method, line 13
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/prod-v1/bsr/cci-ff0c1eb6/recipes/incbin/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 7 (c6b725d14069331426187064956b260f66adf60b):

  • incbin/cci.20211107:
    Error running command conan export --name incbin --version cci.20211107 recipes/incbin/all/conanfile.py:
    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21488/recipes/incbin/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21488/recipes/incbin/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-21488/recipes/incbin/all/conanfile.py", line 2, in <module>
        from conans import CMake
    ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@JonathanGirardeau
Copy link
Contributor

Hello @tomas-krupa, I'm interested in your PR, that would be nice to merge it.
Can you sign the CLA with your @tkrupa account ?
I had the same problem: you signed the CLA with the account that created the PR but when you committed git was configured with an email address that is linked to another account on github: @tkrupa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants