Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recipe for itk/5.3.0 - issue 15104 #23039

Closed
wants to merge 12 commits into from
Closed

Conversation

Ruwei
Copy link

@Ruwei Ruwei commented Mar 9, 2024

itk/5.3.0

This is a dependency of other libraries I want to package. I'm not the author of itk and have limited knowledge with it.


  • I've read the contributing guidelines.

  • I've used a recent Conan client version close to the currently deployed.

  • I've tried at least one configuration locally with the conan-center hook activated.

    The instructions here seem to be wrong and the command "conan config set hooks.conan-center" doesn't work.
    I have tried with one configuration locally without the hook activated.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ Ruwei
✅ AbrilRBS
✅ uilianries
❌ ray-amcax
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 20, 2024
@conan-center-bot conan-center-bot added Version conflict There is a version conflict when solving the dependencies graph and removed User-approval pending labels Aug 20, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi @Ruwei thanks a lot for taking the time to add the new version of itk, we appreciate your effort and patience while we got this thru the backlog of PRs.

As per #23039 (comment), it seems like at least 1 of the commits is authored by ray-amcax which means a CLA sign from that account is also needed, or if you prefer, force-pushing the branch to only have 1 commit comming from you would also be ok. Note that I've updated the branch to allow this to properly build after #23135 was merged :)

@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label Aug 23, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Sep 12, 2024
@uilianries uilianries linked an issue Sep 12, 2024 that may be closed by this pull request
@uilianries
Copy link
Member

I just checked itk cmake files and are looking good, versions 5.2.0 and 5.3.0 differ their macros and included files.

I'll investigate Conan 1.x errors.

@uilianries
Copy link
Member

I could not reproduce the test package error locally, it's working for this recipe revision and package ID.

itk-5.3.0-linux-static.log

I just re-triggered the build again.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS mentioned this pull request Sep 12, 2024
3 tasks
@AbrilRBS
Copy link
Member

AbrilRBS commented Sep 12, 2024

Closing in favour of #25246, where I've kept proper authoring of commits, thanks a lot for your contribution :)

@AbrilRBS AbrilRBS closed this Sep 12, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 47 (ae12d6860a4f626db1fa70b98b7cc429ffd96a3c):

  • itk/5.3.0:
    CI failed to create some packages (All logs)

    Logs for packageID 914c9bd659436536d3d44e89a6310bc0a53a1ad5:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    [options]
    itk:shared=False
    
    [...]
    -- Library tbbmalloc found /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbbmalloc.so
    -- Found: /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbbmalloc.so
    -- Library tbbmalloc_proxy found /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbbmalloc_proxy.so
    -- Found: /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbbmalloc_proxy.so
    -- Library tbb found /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbb.so
    -- Found: /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/onetbb/2021.9.0/_/_/package/7363f5b52b7ab37488a3efc170ec48f8fa87f0b4/lib/libtbb.so
    -- Configuring incomplete, errors occurred!
    See also "/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e/CMakeFiles/CMakeOutput.log".
    CMake Error at /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/itk/5.3.0/_/_/package/914c9bd659436536d3d44e89a6310bc0a53a1ad5/lib/cmake/ITK-5.3/UseITK.cmake:25 (include):
      include could not find load file:
    
        /ITKInitializeCXXStandard.cmake
    Call Stack (most recent call first):
      /home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e/ITKConfig.cmake:3200 (include)
      /home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_package/CMakeLists.txt:5 (find_package)
    
    
    CMake Error at /home/conan/workspace/prod-v1/bsr/95163/cccad/.conan/data/itk/5.3.0/_/_/package/914c9bd659436536d3d44e89a6310bc0a53a1ad5/lib/cmake/ITK-5.3/UseITK.cmake:43 (itk_generate_factory_registration):
      Unknown CMake command "itk_generate_factory_registration".
    Call Stack (most recent call first):
      /home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e/ITKConfig.cmake:3200 (include)
      /home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_package/CMakeLists.txt:5 (find_package)
    
    
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    WARN: gdcm/3.0.23: requirement expat/[>=2.6.2 <3] overridden by itk/5.3.0 to expat/2.6.3 
    WARN: gdcm/3.0.23: requirement zlib/[>=1.2.11 <2] overridden by itk/5.3.0 to zlib/1.3.1 
    WARN: openssl/3.3.1: requirement zlib/[>=1.2.11 <2] overridden by gdcm/3.0.23 to zlib/1.3.1 
    WARN: hdf5/1.14.3: requirement zlib/[>=1.2.11 <2] overridden by itk/5.3.0 to zlib/1.3.1 
    WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by itk/5.3.0 to zlib/1.3.1 
    WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by itk/5.3.0 to zlib/1.3.1 
    itk/5.3.0 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    itk/5.3.0 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    itk/5.3.0 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
    ERROR: itk/5.3.0 (test package): Error in build() method, line 12
    	cmake.configure()
    	ConanException: Error 1 while executing cd '/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="OFF" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="9" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e/package" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_PREFIX_PATH="/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e" -DCMAKE_MODULE_PATH="/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package/build/5d35b214d87bf4539715734840ac1414011e3c4e" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev '/home/conan/workspace/prod-v1/bsr/cci-8bbdfc96/recipes/itk/all/test_v1_package'
    
  • itk/5.1.2:
    Didn't run or was cancelled before finishing

  • itk/5.1.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] itk/5.3.0
7 participants