Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libarchive: bump dependencies #23654

Closed
wants to merge 2 commits into from

Conversation

robomics
Copy link
Contributor

Specify library name and version: libarchive/all


Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/libarchive//'.

👋 @jwillikers you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (94f44db0351e8a5195378314b876bbda3a94d228):

  • libarchive/3.7.3:
    All packages built successfully! (All logs)

  • libarchive/3.7.1:
    All packages built successfully! (All logs)

  • libarchive/3.7.2:
    All packages built successfully! (All logs)

  • libarchive/3.7.4:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (94f44db0351e8a5195378314b876bbda3a94d228):

  • libarchive/3.7.1:
    All packages built successfully! (All logs)

  • libarchive/3.7.3:
    All packages built successfully! (All logs)

  • libarchive/3.7.2:
    All packages built successfully! (All logs)

  • libarchive/3.7.4:
    All packages built successfully! (All logs)

@robomics
Copy link
Contributor Author

robomics commented May 2, 2024

Ping in case this fell through the cracks :) @RubenRBS

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 3, 2024

Hi @robomics thanks a lot for the PR and sorry about the radio silence, we should have communicated a bit better!

The current approach for CCI is to not prioritize PRs that exclusively bump dependencies without a good reasoning behind them (it removes conflicts, a bugfix is needed etc) - Even though this PR falls in this category, not communicating it was a mistake on my end, I know it feels bad when a PR goes unattended for so long for seemingly no reason :/

I'll check if these bumps make sense later today and will come back to you, thanks a lot for your patience

@AbrilRBS AbrilRBS self-assigned this Jul 3, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three bumps seem to introduce more conflicts tyhan they solve. In fact, for pcre and zstd, every other recipe in CCI is also using the old versions, so bumping them here would make the recipe less usable

mdedtls is a bit more chaotic, but we should fix that once the new pipeline is available to fix everything at once

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 3, 2024

Closing as wont-merge, but does not mean we won't tackle this in the future, we'll tidy this up when the new pipeline is ready to go :)

@AbrilRBS AbrilRBS closed this Jul 3, 2024
@robomics
Copy link
Contributor Author

robomics commented Jul 3, 2024

No worries, I understand it is difficult to find the right balance with accepting PRs only bumping dependencies.

On my side, I've switched all my projects from using conanfile.txt to conanfile.py and override dependency's versions as needed. So it is not an issue that this PR was not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants