Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laszip to v3.4.4 #23731

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

tbeu
Copy link
Contributor

@tbeu tbeu commented Apr 23, 2024

Specify library name and version: laszip/3.4.4

This PR also reflects the license change of LASzip.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes May 28, 2024
@AbrilRBS
Copy link
Member

Hi @tbeu thanks a lot for your patience, I've pushed the last changes needed to get this merged :)

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! There is a small detail that will break with this new release:

The version 3.4.4 adds C++17 as requirement. The current recipe is not prepared to work with that, for instance, running older and incompatible compiler will ask for C++17 and will break.

LASzip/LASzip@3.4.3...3.4.4#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR4

As hotfix, I would suggest updating validate(), based on the version and checking for C++17. As reference, you can use this recipe:

if self.settings.get_safe("compiler.cppstd"):

@uilianries uilianries self-assigned this May 31, 2024
@tbeu
Copy link
Contributor Author

tbeu commented May 31, 2024

Did you try to remove the C++17 requirement in the CMakeLists.txt via patch? I still could compile it on MSVC with /std:c++14 set.

@AbrilRBS AbrilRBS self-requested a review June 3, 2024 20:00
@AbrilRBS AbrilRBS removed their assignment Jun 3, 2024
@uilianries
Copy link
Member

Did you try to remove the C++17 requirement in the CMakeLists.txt via patch? I still could compile it on MSVC with /std:c++14 set.

@tbeu In case the project is C++14 compatible, then you should take this information from upstream to be sure. All packages in ConanCenterIndex should follow as close as possible the upstream behavior, to avoid any surprises. So far, I only found a reference about moving to C++17 (LASzip/LASzip@cafdc6b).

@tbeu
Copy link
Contributor Author

tbeu commented Jun 5, 2024

It's at least resolved upstream by LASzip/LASzip@0a20905.

Not sure about any new release though. Should it rather be patched here?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (7cabab2461b32cd52c18c5600962533b6139f500):

  • laszip/3.4.3:
    All packages built successfully! (All logs)

  • laszip/3.4.4:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (7cabab2461b32cd52c18c5600962533b6139f500):

  • laszip/3.4.3:
    All packages built successfully! (All logs)

  • laszip/3.4.4:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 5f63641 into conan-io:master Jun 11, 2024
18 checks passed
@tbeu tbeu deleted the update-laszip-v3.4.4 branch June 12, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants