Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64: add OpenMP support #24552

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 8, 2024

Summary

Changes to recipe: base64/*

Motivation

Adds with_openmp option that defaults to False.

Details

OpenMP is now available for all compilers and without the need to export the necessary compiler and linker flags in package_info() now that #22353 has been merged.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur marked this pull request as draft August 7, 2024 07:15
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (9cc377d550cd1cfa0c554cee556c23f5a9263145):

  • base64/0.5.1:
    Didn't run or was cancelled before finishing

  • base64/0.5.2:
    Didn't run or was cancelled before finishing

  • base64/0.5.0:
    Didn't run or was cancelled before finishing

  • base64/0.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 3f5f3748a40adfea5ffe6321d19d5782099990de:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libstdc++
    compiler.version=13
    os=Linux
    [options]
    base64:shared=False
    
    [...]
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    llvm-openmp/18.1.8: Package installed 80d3c8d077516ce6e7dc913ef92912e9172eae4c
    llvm-openmp/18.1.8: Downloaded package revision ef020f9349d617ca703faa04e8af289a
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    base64/0.4.0: Configuring sources in /home/conan/workspace/prod-v1/bsr/79167/fecea/.conan/data/base64/0.4.0/_/_/source/src
    base64/0.4.0: 
    [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
    [HOOK - conan-center.py] post_source(): [CPPSTD MANAGEMENT (KB-H022)] OK
    [HOOK - conan-center.py] post_source(): [SHORT_PATHS USAGE (KB-H066)] OK
    base64/0.4.0: Copying sources to build folder
    base64/0.4.0: Building your package in /home/conan/workspace/prod-v1/bsr/79167/fecea/.conan/data/base64/0.4.0/_/_/build/3f5f3748a40adfea5ffe6321d19d5782099990de
    base64/0.4.0: Generator txt created conanbuildinfo.txt
    base64/0.4.0: Calling generate()
    base64/0.4.0: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    base64/0.4.0: Calling build()
    base64/0.4.0: Apply patch (conan): add library taget
    base64/0.4.0: Apply patch (conan): provide CMakeLists.txt for MSVC
    
    ----Running------
    > . "/home/conan/workspace/prod-v1/bsr/79167/fecea/.conan/data/base64/0.4.0/_/_/build/3f5f3748a40adfea5ffe6321d19d5782099990de/build-release/conan/conanbuild.sh" && make lib/libbase64.a -j3
    -----------------
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -mavx2 -o lib/arch/avx2/codec.o -c lib/arch/avx2/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -o lib/arch/generic/codec.o -c lib/arch/generic/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic  -o lib/arch/neon32/codec.o -c lib/arch/neon32/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic  -o lib/arch/neon64/codec.o -c lib/arch/neon64/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -mssse3 -o lib/arch/ssse3/codec.o -c lib/arch/ssse3/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -msse4.1 -o lib/arch/sse41/codec.o -c lib/arch/sse41/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -msse4.2 -o lib/arch/sse42/codec.o -c lib/arch/sse42/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -mavx -o lib/arch/avx/codec.o -c lib/arch/avx/codec.c
    clang  -m64 -fPIC -O3 -fopenmp=libomp -std=c99 -O3 -Wall -Wextra -pedantic -o lib/lib.o -c lib/lib.c
    Makefile:101: recipe for target 'lib/lib.o' failed
    base64/0.4.0: 
    lib/lib.c:4:10: fatal error: 'omp.h' file not found
    #include <omp.h>
             ^~~~~~~
    1 error generated.
    make: *** [lib/lib.o] Error 1
    make: *** Waiting for unfinished jobs....
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    base64/0.4.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    base64/0.4.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    base64/0.4.0: ERROR: Package '3f5f3748a40adfea5ffe6321d19d5782099990de' build failed
    base64/0.4.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/79167/fecea/.conan/data/base64/0.4.0/_/_/build/3f5f3748a40adfea5ffe6321d19d5782099990de/build-release
    ERROR: base64/0.4.0: Error in build() method, line 104
    	autotools.make(target="lib/libbase64.a")
    	ConanException: Error 2 while executing make lib/libbase64.a -j3
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (9cc377d550cd1cfa0c554cee556c23f5a9263145):

  • base64/0.5.2:
    Didn't run or was cancelled before finishing

  • base64/0.5.1:
    Didn't run or was cancelled before finishing

  • base64/0.5.0:
    Didn't run or was cancelled before finishing

  • base64/0.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID f2019283ab3ec9255ba07a0e215635eea9214997:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
        llvm-openmp/18.1.8#5e371038846bf9a660dc7746beb21e04:ec2a9de6feab3c0b86da78a55456ffb819b1912b#a999c48a1563d42955e90c4a7918883e - Download (conan-center)
    Build requirements
    Skipped binaries
        cmake/3.30.1
    
    ======== Installing packages ========
    
    -------- Downloading 1 package --------
    llvm-openmp/18.1.8: Retrieving package ec2a9de6feab3c0b86da78a55456ffb819b1912b from remote 'conan-center' 
    llvm-openmp/18.1.8: Package installed ec2a9de6feab3c0b86da78a55456ffb819b1912b
    llvm-openmp/18.1.8: Downloaded package revision a999c48a1563d42955e90c4a7918883e
    base64/0.4.0: Calling source() in /Users/jenkins/workspace/prod-v2/bsr@2/71112/eddbc/p/base6f6fb065df971d/s/src
    base64/0.4.0: Sources for https://github.com/aklomp/base64/archive/v0.4.0.tar.gz found in remote backup https://c3i.jfrog.io/artifactory/conan-center-backup-sources/
    
    -------- Installing package base64/0.4.0 (2 of 2) --------
    base64/0.4.0: Building from source
    base64/0.4.0: Package base64/0.4.0:f2019283ab3ec9255ba07a0e215635eea9214997
    base64/0.4.0: Copying sources to build folder
    base64/0.4.0: Building your package in /Users/jenkins/workspace/prod-v2/bsr@2/71112/eddbc/p/b/base6db0a5ef776edc/b
    base64/0.4.0: Calling generate()
    base64/0.4.0: Generators folder: /Users/jenkins/workspace/prod-v2/bsr@2/71112/eddbc/p/b/base6db0a5ef776edc/b/build-release/conan
    base64/0.4.0: Generating aggregated env files
    base64/0.4.0: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
    base64/0.4.0: Calling build()
    base64/0.4.0: Apply patch (conan): add library taget
    base64/0.4.0: Apply patch (conan): provide CMakeLists.txt for MSVC
    base64/0.4.0: RUN: make lib/libbase64.a -j8
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -mavx2 -o lib/arch/avx2/codec.o -c lib/arch/avx2/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -o lib/arch/generic/codec.o -c lib/arch/generic/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic  -o lib/arch/neon32/codec.o -c lib/arch/neon32/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic  -o lib/arch/neon64/codec.o -c lib/arch/neon64/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -mssse3 -o lib/arch/ssse3/codec.o -c lib/arch/ssse3/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -msse4.1 -o lib/arch/sse41/codec.o -c lib/arch/sse41/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -msse4.2 -o lib/arch/sse42/codec.o -c lib/arch/sse42/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -mavx -o lib/arch/avx/codec.o -c lib/arch/avx/codec.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -o lib/lib.o -c lib/lib.c
    cc  -m64 -fPIC -O3 -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -Xclang -fopenmp -std=c99 -O3 -Wall -Wextra -pedantic -o lib/codec_choose.o -c lib/codec_choose.c
    lib/lib.c:4:10: fatal error: 'omp.h' file not found
    #include <omp.h>
             ^~~~~~~
    1 error generated.
    make: *** [lib/lib.o] Error 1
    make: *** Waiting for unfinished jobs....
    
    base64/0.4.0: ERROR: 
    Package 'f2019283ab3ec9255ba07a0e215635eea9214997' build failed
    base64/0.4.0: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr@2/71112/eddbc/p/b/base6db0a5ef776edc/b/build-release
    ERROR: base64/0.4.0: Error in build() method, line 104
    	autotools.make(target="lib/libbase64.a")
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants