Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendis6: Deprecate in favor of libsersi #24601

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

uilianries
Copy link
Member

Summary

Changes to recipe: opendis6/0.1.0

Motivation

The author decided to rename the project to avoid name collision.

Details

The CI have limitations when renaming packages, so we will first mark this one as deprecated, then, open a second PR only adding a the new recipe.

/cc @crhowell3

Related to #24487


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries self-assigned this Jul 12, 2024
@uilianries uilianries requested a review from AbrilRBS July 12, 2024 07:23
AbrilRBS
AbrilRBS previously approved these changes Jul 12, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

Needed to update the download url to preserve the package url. Otherwise, it would fail, as the project points to another name now to the tag 0.1.0.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor

jcar87 commented Jul 15, 2024

Needed to update the download url to preserve the package url. Otherwise, it would fail, as the project points to another name now to the tag 0.1.0.

have we confirmed the contents are the same?

@uilianries
Copy link
Member Author

have we confirmed the contents are the same?

Yes. The package content is the same as before, the new tag points to the new library name, but repository is the "same", only renamed and continued with new changes.

/cc @crhowell3

@AbrilRBS AbrilRBS self-requested a review July 16, 2024 11:31
@AbrilRBS AbrilRBS assigned AbrilRBS and unassigned AbrilRBS Jul 16, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for new name from upstream

@uilianries uilianries added the blocked Affected by an external issue and waiting until it is solved label Jul 16, 2024
@AbrilRBS AbrilRBS changed the title opendis6: Deprecate in favor of libdis6 opendis6: Deprecate in favor of libsersi Jul 18, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 5 (df2840bd19001f00d252ac1c7ffe3135923be4d4):

  • opendis6/0.1.0:
    CI failed to create some packages (All logs)

    Logs for packageID 66c5327ebdcecae0a01a863939964495fa019a06:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    opendis6:shared=False
    
    [...]
    compiler.version=7
    os=Linux
    [options]
    opendis6:shared=False
    [build_requires]
    [env]
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    opendis6/0.1.0: Forced build from source
    cmake/3.30.0: Not found in local cache, looking in remotes...
    cmake/3.30.0: Trying with 'conan-center'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    cmake/3.30.0: Downloaded recipe revision b93985853f6298c398c76dd4c2ac02a2
    Version ranges solved
        cmake/* versions found in 'conan-center' remote
        Version range '>=3.22 <4' required by 'opendis6/0.1.0' resolved to 'cmake/3.30.0' in remote 'conan-center'
    
    Installing package: opendis6/0.1.0
    Requirements
        opendis6/0.1.0 from local cache - Cache
    Packages
        opendis6/0.1.0:66c5327ebdcecae0a01a863939964495fa019a06 - Build
    Build requirements
        cmake/3.30.0 from 'conan-center' - Downloaded
    Build requirements packages
        cmake/3.30.0:4db1be536558d833e52e862fd84d64d75c2b3656 - Download
    
    Installing (downloading, building) binaries...
    cmake/3.30.0: Retrieving package 4db1be536558d833e52e862fd84d64d75c2b3656 from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    cmake/3.30.0: Package installed 4db1be536558d833e52e862fd84d64d75c2b3656
    cmake/3.30.0: Downloaded package revision 01ff657c4b7a62fc06398e8b0341e952
    cmake/3.30.0: Appending PATH environment variable: /home/conan/workspace/prod-v1/bsr/71592/acbdf/.conan/data/cmake/3.30.0/_/_/package/4db1be536558d833e52e862fd84d64d75c2b3656/bin
    opendis6/0.1.0: Applying build-requirement: cmake/3.30.0
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    opendis6/0.1.0: Configuring sources in /home/conan/workspace/prod-v1/bsr/71592/acbdf/.conan/data/opendis6/0.1.0/_/_/source/src
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    opendis6/0.1.0: WARN: Recipe 'opendis6/0.1.0' is deprecated in favor of 'libsersi'. Please, consider changing your requirements.
    ERROR: opendis6/0.1.0: Error in source() method, line 64
    	get(self, **self.conan_data["sources"][self.version], strip_root=True)
    	ConanException: sha256 signature failed for 'dc1cd3bffdffcabf13b237f270d92cfebf45717c.tar.gz' file. 
     Provided signature: ba519c5421ff63b61893c2d06b3411d0f8a8ea9a90e5a78372f5bd7ec33c7d80  
     Computed signature: b647388dc38404004bcc83021a903a976d68b85ec294a719bdc1c8093a38ea8c
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Affected by an external issue and waiting until it is solved Failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants