Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbgemm: new recipe #24749

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

fbgemm: new recipe #24749

wants to merge 15 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2024

Summary

Changes to recipe: fbgemm/0.8.0

Motivation

FBGEMM offers optimized on-CPU performance for reduced precision calculations used to accelerate deep learning models.

https://github.com/pytorch/FBGEMM

Packaging status

Details

Continues from #4927. Closes #4428.
/cc @SpaceIm

The project specifies C++20 as the standard, but the non-fbgemm_gpu library appears to build fine with C++14.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Aug 11, 2024

Can anyone help out with the Conan v1 failure?

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Aug 21, 2024

@AbrilRBS Can you look into the Conan v1 CI failure, maybe? Perhaps there's something I can fix in my recipe to get rid of it.

@AbrilRBS
Copy link
Member

@valgur seems like the compilation ran out of memory for Conan 1, can't find a clear suspect between all the paralelization, will retry, see if it works now :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Looks like it might be causing test_package failures for Clang:

libfbgemm.so: undefined reference to __gnu_h2f_ieee
@conan-center-bot

This comment has been minimized.

@valgur valgur marked this pull request as draft September 4, 2024 11:10
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 16 (2bacd74cc4ed4f7fe2a7f25df1dc0b56f5b39fb7):

  • fbgemm/0.8.0:
    CI failed to create some packages (All logs)

    Logs for packageID 2c6b4e4e0ccde1d103649b524362e64d7a62a391:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libstdc++
    compiler.version=13
    os=Linux
    [options]
    fbgemm:shared=True
    
    [...]
    fbgemm/0.8.0 (test package): Calling build()
    fbgemm/0.8.0 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/."
    
    ----Running------
    > cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/."
    -----------------
    -- Using Conan toolchain: /home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release/generators/conan_toolchain.cmake
    -- The CXX compiler identification is Clang 13.0.1
    -- Check for working CXX compiler: /usr/local/bin/clang++
    -- Check for working CXX compiler: /usr/local/bin/clang++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'fbgemm'
    -- Conan: Target declared 'asmjit::asmjit'
    -- Conan: Component target declared 'cpuinfo::cpuinfo'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release
    fbgemm/0.8.0 (test package): CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable test_package
    CMakeFiles/test_package.dir/build.make:86: recipe for target 'test_package' failed
    CMakeFiles/Makefile2:75: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:83: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_POLICY_DEFAULT_CMP0091
    
    
    ld: error: /home/conan/workspace/prod-v1/bsr/92416/beabd/.conan/data/fbgemm/0.8.0/_/_/package/2c6b4e4e0ccde1d103649b524362e64d7a62a391/lib/libfbgemm.so: undefined reference to __gnu_h2f_ieee [--no-allow-shlib-undefined]
    ld: error: /home/conan/workspace/prod-v1/bsr/92416/beabd/.conan/data/fbgemm/0.8.0/_/_/package/2c6b4e4e0ccde1d103649b524362e64d7a62a391/lib/libfbgemm.so: undefined reference to __gnu_f2h_ieee [--no-allow-shlib-undefined]
    clang-13: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    fbgemm/0.8.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    fbgemm/0.8.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: fbgemm/0.8.0 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/cci-45553d38/recipes/fbgemm/all/test_package/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (2bacd74cc4ed4f7fe2a7f25df1dc0b56f5b39fb7):

  • fbgemm/0.8.0:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] fbgemm/cci.20210130
4 participants