http_request: new recipe #24778
Open
http_request: new recipe #24778
+134
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment has been minimized.
This comment has been minimized.
AbrilRBS
reviewed
Aug 1, 2024
Comment on lines
+35
to
+45
| def _min_cppstd(self): | ||
| return 17 | ||
|
|
||
| @property | ||
| def _compilers_minimum_version(self): | ||
| return { | ||
| "apple-clang": "10", | ||
| "clang": "7", | ||
| "gcc": "7.1", | ||
| "msvc": "192", | ||
| "Visual Studio": "15.3", |
There was a problem hiding this comment.
There's a missing validate() method to check these values, see the template in https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L80 as to how to do it
| homepage = "https://github.com/Nevermore1994/http-request" | ||
| url = "https://github.com/conan-io/conan-center-index" | ||
| topics = ("http", "https", "modern C++") | ||
| package_type = "library" |
There was a problem hiding this comment.
This seems to be a header-only recipe, so
Suggested change
| package_type = "library" | |
| package_type = "header-only" |
There was a problem hiding this comment.
Checking upstream, there are .cpp files, shouldnt we be building those then?
| package_type = "library" | ||
| settings = "os", "arch", "compiler", "build_type" | ||
| options = { | ||
| "with_openssl": [True, False] |
There was a problem hiding this comment.
In upstream, this option is called DISABLE_HTTPS, we might want to have symmetry there :)
| @@ -0,0 +1,17 @@ | |||
| from conans import ConanFile, CMake, tools | |||
There was a problem hiding this comment.
No need for v1 test packages for new recipes :)
Comment on lines
+74
to
+76
| # TODO: to remove in conan v2 once legacy generators removed | ||
| self.cpp_info.names["cmake_find_package"] = "http_request" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "http_request" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Quite sorry about the incesant bot noise, it got a bit confused there :/ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AbrilRBS
reviewed
Sep 5, 2024
| find_package(http-request REQUIRED CONFIG) | ||
|
|
||
| add_executable(${PROJECT_NAME} test_package.cpp) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE http-request) |
There was a problem hiding this comment.
I modified this to be in line with upstream's cmakelist
Comment on lines
+30
to
+31
| if self.options.with_openssl: | ||
| self.requires("openssl/[>=1.1 <4]") |
There was a problem hiding this comment.
https://github.com/Nevermore1994/http-request#notes seems to note that openssl is required in Windows and not optional. Is this right? Should this not be an option to disable it on Windows? Or how does this work? Thanks!
Conan v1 pipeline ❌Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: http_request/1.0.0
Motivation
A modern C++ lightweight cross-platform HTTP request library
https://github.com/Nevermore1994/http-request
Details
changes