Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe: imgui-sfml #24874

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Aug 8, 2024

Adding a new recipe for imgui-sfml.

Motivation

Close #24676

"Previously available from Bincrafters, but that package is using Conan1 and is no longer being worked on / will not work on Conan2"

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes/imgui-sfml/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only few suggestions.

recipes/imgui-sfml/all/conanfile.py Show resolved Hide resolved
recipes/imgui-sfml/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center and removed Service Under Maintenance labels Aug 9, 2024
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Aug 13, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Aug 13, 2024
@conan-center-bot

This comment has been minimized.

recipes/imgui-sfml/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 6 (19a304e0d26a3fa6ac8e6cdcb7211a071ab18924):

  • imgui-sfml/2.6:
    CI failed to create some packages (All logs)

    Logs for packageID 43ba064ecf27893533f1ac882207947c2173991e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    imgui-sfml:shared=True
    
    [...]
    -- Conan: Target declared 'stb::stb'
    -- Conan: Component target declared 'FLAC::FLAC'
    -- Conan: Component target declared 'FLAC::FLAC++'
    -- Conan: Target declared 'flac::flac'
    -- Conan: Component target declared 'Ogg::ogg'
    -- Conan: Target declared 'OpenAL::OpenAL'
    -- Conan: Target declared 'ALSA::ALSA'
    -- Conan: Including build module from '/home/conan/workspace/prod-v1/bsr/84677/bafcb/.conan/data/openal-soft/1.22.2/_/_/package/1ee54d2403c0a9537bd88ca248c14250a77540ed/lib/cmake/conan-official-openal-soft-variables.cmake'
    -- Conan: Component target declared 'Vorbis::vorbis'
    -- Conan: Component target declared 'Vorbis::vorbisenc'
    -- Conan: Component target declared 'Vorbis::vorbisfile'
    -- Conan: Component target declared 'vorbis::vorbisenc-alias'
    -- Conan: Component target declared 'vorbis::vorbisfile-alias'
    -- Conan: Target declared 'vorbis::vorbis'
    -- Conan: Target declared 'minimp3::minimp3'
    -- Conan: Target declared 'imgui::imgui'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-bef5a2bf/recipes/imgui-sfml/all/test_package/build/Release
    imgui-sfml/2.6 (test package): CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/cci-bef5a2bf/recipes/imgui-sfml/all/test_package/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/workspace/prod-v1/bsr/cci-bef5a2bf/recipes/imgui-sfml/all/test_package/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable test_package
    CMakeFiles/test_package.dir/build.make:124: recipe for target 'test_package' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_POLICY_DEFAULT_CMP0091
    
    
    /usr/bin/ld: test_package: hidden symbol `_ZN5ImGui17GetWindowDrawListEv' in /home/conan/workspace/prod-v1/bsr/84677/bafcb/.conan/data/imgui/1.91.0/_/_/package/66c5327ebdcecae0a01a863939964495fa019a06/lib/libimgui.a(imgui.cpp.o) is referenced by DSO
    /usr/bin/ld: final link failed: Bad value
    collect2: error: ld returned 1 exit status
    make[2]: *** [test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3.1 
    imgui-sfml/2.6 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    imgui-sfml/2.6 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: imgui-sfml/2.6 (test package): Error in build() method, line 22
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/cci-bef5a2bf/recipes/imgui-sfml/all/test_package/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 6 (19a304e0d26a3fa6ac8e6cdcb7211a071ab18924):

  • imgui-sfml/2.6:
    CI failed to create some packages (All logs)

    Logs for packageID b471c862f0beafcae693d4fac83983edb539582f:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=True
    
    [...]
          ImGui::DrawRect(sf::Rect<float> const&, sf::Color const&, float, int, float) in imgui-SFML.cpp.o
          ImGui::DrawRectFilled(sf::Rect<float> const&, sf::Color const&, float, int) in imgui-SFML.cpp.o
      "ImGui::GetIO()", referenced from:
          ImGui::SFML::Init(sf::Window&, sf::Vector2<float> const&, bool) in imgui-SFML.cpp.o
          ImGui::SFML::UpdateFontTexture() in imgui-SFML.cpp.o
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
          ImGui::SFML::Update(sf::Window&, sf::RenderTarget&, sf::Time) in imgui-SFML.cpp.o
          ImGui::SFML::Update(sf::Vector2<int> const&, sf::Vector2<float> const&, sf::Time) in imgui-SFML.cpp.o
          (anonymous namespace)::RenderDrawLists(ImDrawData*) in imgui-SFML.cpp.o
      "ImGui::Image(void*, ImVec2 const&, ImVec2 const&, ImVec2 const&, ImVec4 const&, ImVec4 const&)", referenced from:
          ImGui::Image(sf::Texture const&, sf::Color const&, sf::Color const&) in imgui-SFML.cpp.o
          ImGui::Image(sf::Texture const&, sf::Vector2<float> const&, sf::Color const&, sf::Color const&) in imgui-SFML.cpp.o
          ImGui::Image(sf::RenderTexture const&, sf::Color const&, sf::Color const&) in imgui-SFML.cpp.o
          ImGui::Image(sf::RenderTexture const&, sf::Vector2<float> const&, sf::Color const&, sf::Color const&) in imgui-SFML.cpp.o
          ImGui::Image(sf::Sprite const&, sf::Vector2<float> const&, sf::Color const&, sf::Color const&) in imgui-SFML.cpp.o
      "ImGui::Render()", referenced from:
          ImGui::SFML::Render(sf::RenderWindow&) in imgui-SFML.cpp.o
          ImGui::SFML::Render(sf::RenderTarget&) in imgui-SFML.cpp.o
          ImGui::SFML::Render() in imgui-SFML.cpp.o
      "ImGui::NewFrame()", referenced from:
          ImGui::SFML::Update(sf::Vector2<int> const&, sf::Vector2<float> const&, sf::Time) in imgui-SFML.cpp.o
      "ImGuiIO::AddKeyEvent(ImGuiKey, bool)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
          ImGui::SFML::Update(sf::Vector2<int> const&, sf::Vector2<float> const&, sf::Time) in imgui-SFML.cpp.o
      "ImGuiIO::AddFocusEvent(bool)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
      "ImGuiIO::AddMousePosEvent(float, float)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
      "ImGuiIO::AddInputCharacter(unsigned int)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
      "ImGuiIO::AddKeyAnalogEvent(ImGuiKey, bool, float)", referenced from:
          ImGui::SFML::Update(sf::Vector2<int> const&, sf::Vector2<float> const&, sf::Time) in imgui-SFML.cpp.o
      "ImGuiIO::AddMouseWheelEvent(float, float)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
      "ImGuiIO::AddMouseButtonEvent(int, bool)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
      "ImGuiIO::SetKeyEventNativeData(ImGuiKey, int, int, int)", referenced from:
          ImGui::SFML::ProcessEvent(sf::Event const&) in imgui-SFML.cpp.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [libImGui-SFML.dylib] Error 1
    make[1]: *** [CMakeFiles/ImGui-SFML.dir/all] Error 2
    make: *** [all] Error 2
    
    imgui-sfml/2.6: ERROR: 
    Package 'b471c862f0beafcae693d4fac83983edb539582f' build failed
    imgui-sfml/2.6: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr/76272/facdd/p/b/imgui04a796c5f1f07/b/build/Release
    ERROR: imgui-sfml/2.6: Error in build() method, line 74
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] imgui-sfml/2.6
6 participants