-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocksdb: add version 9.6.1 #25183
base: master
Are you sure you want to change the base?
rocksdb: add version 9.6.1 #25183
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hey @toge 👋 Could you explain to where the |
@ErniGH |
@@ -27,6 +30,10 @@ sources: | |||
url: "https://github.com/facebook/rocksdb/archive/refs/tags/v6.20.3.tar.gz" | |||
sha256: "c6502c7aae641b7e20fafa6c2b92273d935d2b7b2707135ebd9a67b092169dca" | |||
patches: | |||
"9.6.1": | |||
- patch_file: "patches/9.6.1-0001-support-clang.patch" | |||
patch_description: "Fix build with gcc 13 by including cstdint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @toge this is a bit suprising for me. the patch description makes it look like it will only be adding #include <cstdin>
where necessary, but the diff here (and in the linked PR) seems to be quite bigger in scope than just that. Could you elaborate into what it ecxactly is doing? Thanks!
Summary
Changes to recipe: rocksdb/9.6.1
Motivation
There are several improvements in 9.6.1.
Details
facebook/rocksdb@v9.5.2...v9.6.1