Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: add version 9.6.1 #25183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rocksdb: add version 9.6.1 #25183

wants to merge 1 commit into from

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 8, 2024

Summary

Changes to recipe: rocksdb/9.6.1

Motivation

There are several improvements in 9.6.1.

Details

facebook/rocksdb@v9.5.2...v9.6.1


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (2bd3f91e1bc138c0806d761c7c37701f86bbb0e4):

  • rocksdb/9.5.2:
    All packages built successfully! (All logs)

  • rocksdb/9.6.1:
    All packages built successfully! (All logs)

  • rocksdb/6.20.3:
    All packages built successfully! (All logs)

  • rocksdb/9.2.1:
    All packages built successfully! (All logs)

  • rocksdb/9.1.0:
    All packages built successfully! (All logs)

  • rocksdb/9.4.0:
    All packages built successfully! (All logs)

  • rocksdb/8.8.1:
    All packages built successfully! (All logs)

  • rocksdb/6.27.3:
    All packages built successfully! (All logs)

  • rocksdb/6.29.5:
    All packages built successfully! (All logs)

  • rocksdb/9.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (2bd3f91e1bc138c0806d761c7c37701f86bbb0e4):

  • rocksdb/9.5.2:
    All packages built successfully! (All logs)

  • rocksdb/8.8.1:
    All packages built successfully! (All logs)

  • rocksdb/9.2.1:
    All packages built successfully! (All logs)

  • rocksdb/9.6.1:
    All packages built successfully! (All logs)

  • rocksdb/9.4.0:
    All packages built successfully! (All logs)

  • rocksdb/9.1.0:
    All packages built successfully! (All logs)

  • rocksdb/6.29.5:
    All packages built successfully! (All logs)

  • rocksdb/9.0.0:
    All packages built successfully! (All logs)

  • rocksdb/6.20.3:
    All packages built successfully! (All logs)

  • rocksdb/6.27.3:
    All packages built successfully! (All logs)

@ErniGH ErniGH self-assigned this Sep 9, 2024
@ErniGH
Copy link
Contributor

ErniGH commented Sep 9, 2024

Hey @toge 👋 Could you explain to where the 9.6.1-0001-support-clang patch came from? Is there any PR or any discussion that explains it?

@toge
Copy link
Contributor Author

toge commented Sep 9, 2024

@ErniGH
Sorry I created PR.
facebook/rocksdb#13002

@@ -27,6 +30,10 @@ sources:
url: "https://github.com/facebook/rocksdb/archive/refs/tags/v6.20.3.tar.gz"
sha256: "c6502c7aae641b7e20fafa6c2b92273d935d2b7b2707135ebd9a67b092169dca"
patches:
"9.6.1":
- patch_file: "patches/9.6.1-0001-support-clang.patch"
patch_description: "Fix build with gcc 13 by including cstdint"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toge this is a bit suprising for me. the patch description makes it look like it will only be adding #include <cstdin> where necessary, but the diff here (and in the linked PR) seems to be quite bigger in scope than just that. Could you elaborate into what it ecxactly is doing? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants