Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libid3tag: set pkg_config_name #25301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 18, 2024

Summary

Changes to recipe: libid3tag/[*]

Motivation

Most if not all package managers install a id3tag.pc file for the libid3tag package, but not CCI:

Causes imlib2 configure step to fail.

Details


@valgur valgur mentioned this pull request Sep 18, 2024
5 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (478503d958675d0ec5bfb342cac0c4daacc70028):

  • libid3tag/0.15.1b:
    Built 20 packages out of 22 (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 1 (478503d958675d0ec5bfb342cac0c4daacc70028):

  • libid3tag/0.15.1b:
    CI failed to create some packages (All logs)

    Logs for packageID c2b0b614e90340d2e6ee07f163e7c5252c078301:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=True
    
    [...]
    libid3tag/0.15.1b (test package): CMakeToolchain generated: /Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package/CMakeUserPresets.json
    libid3tag/0.15.1b (test package): Generator 'VirtualRunEnv' calling 'generate()'
    libid3tag/0.15.1b (test package): Generating aggregated env files
    libid3tag/0.15.1b (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']
    
    ======== Testing the package: Building ========
    libid3tag/0.15.1b (test package): Calling build()
    libid3tag/0.15.1b (test package): Running CMake.configure()
    libid3tag/0.15.1b (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package"
    -- Using Conan toolchain: /Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package/build/apple-clang-13-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: Defining architecture flag: -m64
    -- Conan toolchain: Defining libcxx as C++ flags: -stdlib=libc++
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The C compiler identification is AppleClang 13.0.0.13000029
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Conan: Target declared 'libid3tag::libid3tag'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package/build/apple-clang-13-x86_64-17-release
    
    libid3tag/0.15.1b (test package): Running CMake.build()
    libid3tag/0.15.1b (test package): RUN: cmake --build "/Users/jenkins/workspace/prod-v2/bsr/cci-e58f5301/recipes/libid3tag/all/test_package/build/apple-clang-13-x86_64-17-release" -- -j8
    [ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
    [100%] Linking C executable test_package
    ld: warning: ignoring file /Users/jenkins/workspace/prod-v2/bsr/86392/dfdaf/p/b/libid7e3d78418074c/p/lib/libid3tag.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
    Undefined symbols for architecture x86_64:
      "_id3_author", referenced from:
          _main in test_package.c.o
      "_id3_build", referenced from:
          _main in test_package.c.o
      "_id3_copyright", referenced from:
          _main in test_package.c.o
      "_id3_tag_version", referenced from:
          _main in test_package.c.o
      "_id3_version", referenced from:
          _main in test_package.c.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    
    ERROR: libid3tag/0.15.1b (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

Hooks produced the following warnings for commit 478503d
libid3tag/0.15.1b@#2c3df0d43a7709bb13c0563dfd8ce107
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libid3tag.0.3.0.dylib, libid3tag.0.dylib, libid3tag.dylib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants