Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuvc: remove deprecated libjpeg-turbo option #25387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perseoGI
Copy link
Contributor

Summary

Changes to recipe: libuvc/all

Motivation

We have found an error thanks to the experimental conan linter:

recipes/libuvc/all/conanfile.py::53:16 - W0104: Statement seems to have no effect (pointless-statement)
╭────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│    52             if self.options.jpeg_turbo:                                                                                                                              │
│    53                 self.options.with_jpeg == "libjpeg-turbo"                                                                                                            │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

We have decided to fully remove this option deprecated two years ago which was incorrectly programmed.


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option has been deprecated for almost 2 years now 👍

@AbrilRBS AbrilRBS removed their assignment Sep 24, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (e05ef07120cd8cb0c3de65342dfea02ce736c7c8):

  • libuvc/0.0.6:
    Built 16 packages out of 22 (All logs)

  • libuvc/0.0.7:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (e05ef07120cd8cb0c3de65342dfea02ce736c7c8):

  • libuvc/0.0.7:
    Built 6 packages out of 10 (All logs)

  • libuvc/0.0.6:
    Built 6 packages out of 10 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants