-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for python312 #76
Rebuild for python312 #76
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
a0344d1
to
8ee1e3a
Compare
…nda-forge-pinning 2023.10.07.18.27.00
bddd4ba
to
4b1f6a1
Compare
@conda-forge/aiohttp For this purpose, I ensured we run the test suite (modulo some existing failures), which was not as straight-forward as I had hoped (normally I build from source and then just pipe the And as it turns out, the minimal test skips for 3.9.0b3 are barely different than the ones for 3.8.6, arguably even better. From my POV we could merge this as-is, but would be happy to hear other people's thoughts. |
I'd personally be happy with it, but I'm eager to get more of the 3.12 tree done. One option we could consider is only building 3.9.0b3 for 3.12 (probably on a separate branch) and keep a more normal bump for when 3.9.0 final comes out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this PR but let's wait for @xhochy's ok before we merge it. (I believe the other maintainer is MIA.)
I'd be fine with that, though I'd just add
for the moment, and merge to main. |
I have been a bit hesitant with this in the past days as this is a beta release but given that upstream has received a bit of testing but no severe issues, I'm fine with going ahead with this being Python 3.12 only. |
This PR has been triggered in an effort to update python312.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6445354854, please use this URL for debugging.