Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #76

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6445354854, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the rebuild-python312-0-1_hbee979 branch 7 times, most recently from a0344d1 to 8ee1e3a Compare October 8, 2023 09:26
@h-vetinari h-vetinari force-pushed the rebuild-python312-0-1_hbee979 branch from bddd4ba to 4b1f6a1 Compare October 8, 2023 11:42
@h-vetinari
Copy link
Member

@conda-forge/aiohttp
I spent more time on this than I wanted but oh well, it's a Sunday. The issue is that even the very latest 3.8.6 will not support Python 3.12, and there's nothing easily backportable. The only feasible solution is to take the next version, the first minor bump of aiohttp in almost 2 years. Upstream released a beta, and I wanted to get a feel how much we could rely on it (perhaps already merge the beta, because >800 packages are waiting on this in the migration).

For this purpose, I ensured we run the test suite (modulo some existing failures), which was not as straight-forward as I had hoped (normally I build from source and then just pipe the tests folder through to the test section with source_files:, but here, building from source turned into a yak shave that I eventually gave up, see 9e8269d).

And as it turns out, the minimal test skips for 3.9.0b3 are barely different than the ones for 3.8.6, arguably even better.

From my POV we could merge this as-is, but would be happy to hear other people's thoughts.

@dopplershift
Copy link
Member

I'd personally be happy with it, but I'm eager to get more of the 3.12 tree done. One option we could consider is only building 3.9.0b3 for 3.12 (probably on a separate branch) and keep a more normal bump for when 3.9.0 final comes out.

Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this PR but let's wait for @xhochy's ok before we merge it. (I believe the other maintainer is MIA.)

@h-vetinari
Copy link
Member

h-vetinari commented Oct 9, 2023

One option we could consider is only building 3.9.0b3 for 3.12 (probably on a separate branch) and keep a more normal bump for when 3.9.0 final comes out.

I'd be fine with that, though I'd just add

# 3.9.0b0 is the only 3.12-capable release, wait for GA for other pythons
skip: true  # [py<312]

for the moment, and merge to main.

@xhochy
Copy link
Member

xhochy commented Oct 10, 2023

I have been a bit hesitant with this in the past days as this is a beta release but given that upstream has received a bit of testing but no severe issues, I'm fine with going ahead with this being Python 3.12 only.

@xhochy xhochy merged commit 2c9c000 into conda-forge:main Oct 10, 2023
37 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python312-0-1_hbee979 branch October 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants