Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perl as a run dep #8

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Add perl as a run dep #8

merged 2 commits into from
Jun 2, 2016

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jun 2, 2016

Ping @kmuehlbauer this might help fix our problems.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kmuehlbauer
Copy link

Seems it needs perl also at build time...

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 2, 2016

Seems it needs perl also at build time...

I did that to investigate if autoconf was the right place for the perl dependency here, but I guess m4 is. (At least my Linux distro builds m4 with perl.)

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 2, 2016

I don't know what is causing the perl conflict. It is definitely not m4 which is the only dependency for autoconf.

Error:  Package missing in current linux-64 channels: 
  - perl 5.18.2*

@msarahan do you have any idea of what I am doing wrong here?

@msarahan
Copy link
Member

msarahan commented Jun 2, 2016

Yeah, conda's dumb in this case. The default Perl version is the one you see, but that's not available. Pin to >=5.20 and it should work.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 2, 2016

Thanks @msarahan! That solved it!! We need to figure out a pinning strategy for perl and add it here.

Does perl 5.20.* sounds OK? If so I can put a PR to add that to the pin_the_slow_way.py script. (Ping @pelson.)

@jakirkham
Copy link
Member

I thought we fixed this perl issue. @pelson, any idea why it still doesn't respect the version in the feedstock?

@ocefpaf ocefpaf merged commit a2fe4be into conda-forge:master Jun 2, 2016
@ocefpaf ocefpaf deleted the try_perl branch June 2, 2016 16:10
@pelson
Copy link
Member

pelson commented Jun 2, 2016

I thought we fixed this perl issue. @pelson, any idea why it still doesn't respect the version in the feedstock?

Good question. I definitely added conda-build-all perl support (https://github.com/SciTools/conda-build-all/blob/master/conda_build_all/version_matrix.py#L217) so yes, the CONDA_PERL environment variable should be being set appropriately (and automatically).

@jakirkham
Copy link
Member

jakirkham commented Jun 3, 2016

Ah, but we didn't add it to conda-smithy. ( conda-forge/conda-smithy#190 )

@jakirkham
Copy link
Member

FYI this is not the last time perl issues will come out of the woodwork. I expect to see several in the near future. We were implicitly depending on perl that was installed with git from yum. However, we now use our git that does not install perl currently (may change). As a result, a few packages may need to be fixed to have perl as a build and/or run time dependency.

@jakirkham
Copy link
Member

FYI automake had the same issue, but it is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants