Skip to content

Commit

Permalink
revert a patch that causes _availability_version_check to not be fo…
Browse files Browse the repository at this point in the history
…und (#120)

automerged PR by conda-forge/automerge-action
  • Loading branch information
github-actions[bot] committed Sep 2, 2024
2 parents 9d14a80 + cb0a805 commit 3881104
Show file tree
Hide file tree
Showing 12 changed files with 52 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .azure-pipelines/azure-pipelines-win.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .ci_support/linux_64_.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
c_stdlib:
- sysroot
c_stdlib_version:
- '2.12'
- '2.17'
cdt_name:
- cos6
- cos7
channel_sources:
- conda-forge
channel_targets:
- conda-forge main
cxx_compiler:
- gxx
cxx_compiler_version:
- '12'
- '13'
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
libxml2:
Expand Down
2 changes: 1 addition & 1 deletion .ci_support/linux_aarch64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ channel_targets:
cxx_compiler:
- gxx
cxx_compiler_version:
- '12'
- '13'
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
libxml2:
Expand Down
2 changes: 1 addition & 1 deletion .ci_support/linux_ppc64le_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ channel_targets:
cxx_compiler:
- gxx
cxx_compiler_version:
- '12'
- '13'
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
libxml2:
Expand Down
2 changes: 1 addition & 1 deletion .ci_support/osx_64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ channel_targets:
cxx_compiler:
- clang_bootstrap
cxx_compiler_version:
- '16'
- '17'
libxml2:
- '2'
macos_machine:
Expand Down
2 changes: 1 addition & 1 deletion .ci_support/osx_arm64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ channel_targets:
cxx_compiler:
- clang_bootstrap
cxx_compiler_version:
- '16'
- '17'
libxml2:
- '2'
macos_machine:
Expand Down
1 change: 0 additions & 1 deletion .scripts/build_steps.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .scripts/run_osx_build.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions build-locally.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ source:
sha256: 09c08693a9afd6236f27a2ebae62cda656eba19021ef3f94d59e931d662d4856
patches:
- patches/0001-no-code-sign.patch
- patches/0002-Revert-Declare-_availability_version_check-as-weak_i.patch

build:
number: 0
number: 1

requirements:
build:
Expand Down
4 changes: 2 additions & 2 deletions recipe/patches/0001-no-code-sign.patch
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From bf3c5b20918704c6f07f5aecef840376fd3b0806 Mon Sep 17 00:00:00 2001
From dd35ef6087b81d9d7fc658f1c35557eec1cb733f Mon Sep 17 00:00:00 2001
From: Isuru Fernando <isuruf@gmail.com>
Date: Mon, 22 Apr 2019 02:00:30 -0500
Subject: [PATCH] no code sign
Subject: [PATCH 1/2] no code sign

---
compiler-rt/cmake/Modules/AddCompilerRT.cmake | 28 -------------------
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
From d37bc1428cd192a6fa3a967a509805b95a761910 Mon Sep 17 00:00:00 2001
From: "H. Vetinari" <h.vetinari@gmx.com>
Date: Mon, 2 Sep 2024 14:30:13 +1100
Subject: [PATCH 2/2] Revert "Declare _availability_version_check as
weak_import instead of looking it"

This reverts commit b653a2823fe4b4c9c6d85cfe119f31d8e70c2fa0.
---
compiler-rt/lib/builtins/os_version_check.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/compiler-rt/lib/builtins/os_version_check.c b/compiler-rt/lib/builtins/os_version_check.c
index 182eabe7a6ae..ebfb2dfc72dd 100644
--- a/compiler-rt/lib/builtins/os_version_check.c
+++ b/compiler-rt/lib/builtins/os_version_check.c
@@ -86,10 +86,6 @@ typedef Boolean (*CFStringGetCStringFuncTy)(CFStringRef, char *, CFIndex,
CFStringEncoding);
typedef void (*CFReleaseFuncTy)(CFTypeRef);

-extern __attribute__((weak_import))
-bool _availability_version_check(uint32_t count,
- dyld_build_version_t versions[]);
-
static void _initializeAvailabilityCheck(bool LoadPlist) {
if (AvailabilityVersionCheck && !LoadPlist) {
// New API is supported and we're not being asked to load the plist,
@@ -98,8 +94,8 @@ static void _initializeAvailabilityCheck(bool LoadPlist) {
}

// Use the new API if it's is available.
- if (_availability_version_check)
- AvailabilityVersionCheck = &_availability_version_check;
+ AvailabilityVersionCheck = (AvailabilityVersionCheckFuncTy)dlsym(
+ RTLD_DEFAULT, "_availability_version_check");

if (AvailabilityVersionCheck && !LoadPlist) {
// New API is supported and we're not being asked to load the plist,

0 comments on commit 3881104

Please sign in to comment.