Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sha for 3.9.1 #43

Merged
merged 1 commit into from
Apr 25, 2018
Merged

fix sha for 3.9.1 #43

merged 1 commit into from
Apr 25, 2018

Conversation

msarahan
Copy link
Member

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

jakirkham commented Apr 25, 2018

Thanks Mike. LGTM.

Side note: It seems we require pip, but then don't use it. Should we be using pip to do the install or should we switch the requirement back to setuptools?

Edit: Raised the side note as issue ( #44 ).

@msarahan
Copy link
Member Author

shrug doesn't matter to me. More concerned with the big rebuild effort right now. Go ahead with whatever cleanup you want to do.

@jakirkham jakirkham merged commit c1b9bba into conda-forge:master Apr 25, 2018
@jakirkham
Copy link
Member

Thanks Mike.

Opted to just merge it (as it isn't really related to this PR). Created issue ( #44 ) to point out that pip isn't being used and try to get feedback from others/fix it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants