Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mamba install #585

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Use Mamba install #585

merged 1 commit into from
Mar 22, 2024

Conversation

jakirkham
Copy link
Member

Heroku is running out of memory during the build. Switch back to Mamba for the install to see if that helps.

Checklist

  • Pushed the branch to main repo
  • CI passed on the branch

Heroku is running out of memory during the build. Switch back to Mamba
for the install to see if that helps.
@jakirkham jakirkham merged commit 5e87e19 into main Mar 22, 2024
1 check passed
@jakirkham jakirkham deleted the use_mamba_install branch March 22, 2024 03:59
@jakirkham
Copy link
Member Author

Here is the Heroku log

@jakirkham
Copy link
Member Author

@beckermr success! 🎉

@jakirkham
Copy link
Member Author

Testing a re-render to make sure things are working: conda-forge/ucx-split-feedstock#162

@jakirkham
Copy link
Member Author

Seems to be working

@mbargull
Copy link
Member

FYI, you most likely ran into conda/conda#13541 (comment) which caused a sharp memory usage spike with the latter being avoided in conda>=24.3 via conda/conda#13628 .
But even with conda=24.1 you'd probably not run into that issue -- for conda-forge at least -- since the code for repodata.json.zst support does not take that problematic code path.

IOW, the issue was most likely due to having conda<=23.11 in our installers and once we update to conda>=24.1 (or better, conda>=24.3), the peak memory usage should be about the same whether conda or mamba is used.

@hmaarrfk
Copy link

we are probably due for a new release of miniforge then.

@mbargull
Copy link
Member

Yes, but no particular rush, IMO. The bug mentioned above has been present in conda>=4.12,<24.3, so not a particular new thing ;).

@jakirkham
Copy link
Member Author

Explains why we didn't see it before. This was using 4.11.0 previously (with Mamba)

We just updated ( #580 ) 😬

A new release would be welcome, but agree not a rush. We have cobbled together a working solution to tide us over until then

@jakirkham
Copy link
Member Author

Started updating Miniforge in a follow up PR ( #598 ). Though maybe we can go to 24.3 if that is ready ( conda-forge/miniforge#574 )

@jakirkham
Copy link
Member Author

jakirkham commented Apr 16, 2024

We have now upgraded to Miniforge 24.3.0 and are using Conda again for installs ( #598 ). Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants