Windows: Catch all non-zero exit codes (negative values too) #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jaimergp
force-pushed
the
fix-conda-build-error-handling
branch
from
85c2a5a
to
815853f
Compare
|
We should have this as a linter message for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrySupersedes #1704. The formula
if errorlevel 1actually means "if the exit code is >=1", so it doesn't catch-1and other negative exit codes. This can happen in conda-build when it segfaults during the linkage analysis steps, for example.Exit codes in CMD are tricky and there are many gotchas. Since we can afford to enable delayed expansion, this is relatively robust. See this SO answer for (way ) more info if you are curious.