fix: read feedstock name from rattler-build feedstock

[nichmor]

Checklist

• Added a news entry
• Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

Fix invoking conda-smithy register-github and conda-smithy register-ci when rattler-build recipe.yaml is used in feedstock.

[nichmor]

@beckermr @jaimergp

[wolfv]

Will this work with a fresh feedstock? Because I am not sure if we will have the right forge_config.

[beckermr]

@nichmor did you see this comment?

[beckermr]

No api changes.

[baszalmstra]

@beckermr Can you elaborate what you mean by this? Are you refering to the move of the private functions? Or did we miss something?

[beckermr]

Only functions that start with an underscore are private in python. Anything else is a public api and cannot be moved or renamed.

[baszalmstra]

I thought thats exactly what we did? Did we accidentally move non-underscorred functions?

[beckermr]

Upper bound should be ",<2.0.0a0".

[nichmor]

Upper bound should be ",<2.0.0a0".

changed

[isuruf]

Can we keep the functions you moved to utils.py in configure_feedstock.py? It doesn't make sense to me to move them to a different file.

[baszalmstra]

Can we keep the functions you moved to utils.py in configure_feedstock.py? It doesn't make sense to me to move them to a different file.

In not sure I understand. In trying to understand this better. From my perspective _load_forge_config is the only function that is now used in configure_feedstock and it is used in a few different other functionality with this PR. Why doesnt it make sense to have this common functionality in a seperate file? What makes this tightly coupled to configure_feedstock?

[isuruf]

I missed that. However _load_forge_config is a configuration file for the feedstock and belongs in configure_feedstock. It does not make sense at all to use utils.py which is a generic name. Why not import from conda_smithy.configure_feedstock?

[nichmor]

Can we keep the functions you moved to utils.py in configure_feedstock.py? It doesn't make sense to me to move them to a different file.

Hey @isuruf !
We introduced the utility function get_feedstock_name_from_metadata which I've decided to keep in utils.py as it's not tightly coupled to configure_feedstock.py.
Unfortunately while trying to import other utility functions from configure_feedstock.py I had a circular import, so I've decided to put them in the utils module, as it more makes sense based on their responsibility

[isuruf]

Unfortunately while trying to import other utility functions from configure_feedstock.py I had a circular import, so I've decided to put them in the utils module, as it more makes sense based on their responsibility

utils module makes sense based on the responsibility? utils module doesn't have any responsibility. It's a bad design to move functionality to a generic utils name.

[isuruf]

See https://breadcrumbscollector.tech/stop-naming-your-python-modules-utils/

[baszalmstra]

Sure, I agree! But maybe we can just think of a better name instead? conda_forge_config for instance? To work around circular import issue.

[isuruf]

Where is the circular import coming from? You can import inside a function instead of at a top-level to avoid circular imports.

[nichmor]

hey @isuruf ! I've reverted the files in their old locations

[nichmor]

@isuruf removed the indirection

[beckermr]

LGTM from me but we should wait for Isuru.