Add a bash/sh/zsh guard to avoid users running build-localy with them #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I keep typing ``` bash build-\tab ``` which causes all kinds of problems. I think this would help me and likely others
hmaarrfk
commented
Aug 12, 2024
| @@ -1,8 +1,10 @@ | |||
| #!/usr/bin/env python3 | |||
| #!/bin/sh | |||
| '''exec' "python3" "$0" "$@" #''' | |||
There was a problem hiding this comment.
Hmm this is even cooler.
My fear is that this encourages bad habits. but ok!
|
Well CIs are green, so this is here if there is some enthusiasm around it. |
ocefpaf
reviewed
Sep 5, 2024
| @@ -1,8 +1,11 @@ | |||
| #!/usr/bin/env python3 | |||
| #!/bin/sh | |||
| """exec' "python3" "$0" "$@" #""" # fmt: off # fmt: on | |||
There was a problem hiding this comment.
This broken the script for those calling it with ./build-locally.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep typing
which causes all kinds of problems. I think this would help me and likely others
Checklist
newsentry <--- Is this needed?python conda_smithy/schema.py)