feat: add linting for pip build backend #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@conda-forge/core This PR is ready for review! |
beckermr
commented
Aug 22, 2024
beckermr
commented
Aug 22, 2024
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
xhochy
reviewed
Aug 22, 2024
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
isuruf
reviewed
Aug 22, 2024
|
Test failure is for coveralls and not related to this PR. going to merge. |
h-vetinari
reviewed
Sep 1, 2024
| @@ -185,3 +206,15 @@ def _lint_package_version(version: Optional[str]) -> Optional[str]: | |||
| VersionOrder(ver) | |||
| except InvalidVersionSpec as e: | |||
| return invalid_version.format(ver=ver, err=e) | |||
|
|
|||
|
|
|||
| @lru_cache(maxsize=1) | |||
There was a problem hiding this comment.
What's the lifetime of this cache? I'm not too sure how the linter is currently set up, but if it's a long-running deployment, that would basically mean we have to redeploy to pick up changes in the hints.toml from the pinning repo...?
There was a problem hiding this comment.
Good point. We should use something like this (https://stackoverflow.com/a/63674816), though I think that specific code has edge cases when it could avoid them.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)