Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings to deprecate Mambaforge #615

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Add warnings to deprecate Mambaforge #615

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b9109b5
Add warnings to deprecate Mambaforge
jaimergp Jul 24, 2024
201500e
missing space
jaimergp Jul 24, 2024
fe452a7
missing then
jaimergp Jul 24, 2024
f079b7c
missing pipe
jaimergp Jul 24, 2024
80a37aa
Address code review
jaimergp Jul 25, 2024
8859ead
Update README.md
jaimergp Jul 25, 2024
1de423b
Update .github/workflows/ci.yml
jaimergp Jul 25, 2024
e929bae
Do pass $MINIFORGE_LICENSE_OVERRIDE
jaimergp Jul 25, 2024
beafb76
Add brownouts
jaimergp Jul 25, 2024
2c85061
Update README.md
beckermr Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ jobs:
miniforge-variant: Mambaforge
use-mamba: true
if: ${{ ! contains(matrix.OS_NAME, 'Linux') }}

- name: Patch license for Mambaforge deprecation
if: matrix.MINIFORGE_NAME == 'Mambaforge'
jaimergp marked this conversation as resolved.
Show resolved Hide resolved
run: |
echo "!!!!!! Mambaforge is now deprecated !!!!!" > MAMBAFORGE_LICENSE.txt
echo "Future Miniforge releases will NOT build Mambaforge installers." >> MAMBAFORGE_LICENSE.txt
echo "We advise you switch to Miniforge at your earliest convenience." >> MAMBAFORGE_LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, Miniforge vs Miniforge3..... naming decisions that come back to haunt us!!!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... And how it's Miniforge3 for CPython but just Miniforge for PyPy :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!!!

echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" >> MAMBAFORGE_LICENSE.txt
cat LICENSE >> MAMBAFORGE_LICENSE.txt
echo "MINIFORGE_LICENSE_OVERRIDE=../MAMBAFORGE_LICENSE.txt" >> $GITHUB_ENV

- name: Build and test miniforge
env:
Expand Down
5 changes: 4 additions & 1 deletion Miniforge3/construct.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ write_condarc: True
# keep pkgs for space-saving implications for hardlinks when create new environments
# and keep the same with Miniconda
keep_pkgs: True
license_file: ../LICENSE
license_file: {{ os.environ.get("MINIFORGE_LICENSE_OVERRIDE", "../LICENSE") }}

# During the interactive installation, these variables are checked.
# During batch installation, conda is never initialized
Expand Down Expand Up @@ -48,3 +48,6 @@ specs:

- pip
- miniforge_console_shortcut 1.* # [win]

pre_install: mambaforge_deprecation.sh # [unix]
pre_install: mambaforge_deprecation.bat # [win]
8 changes: 8 additions & 0 deletions Miniforge3/mambaforge_deprecation.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
if "%GITHUB_ACTIONS%"=="true" (
echo ::warning title=Mambaforge is now deprecated!::Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience.
)
else (
msg "%sessionname%" Mambaforge is now deprecated! Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience.
)
echo Sleeping for 30s...
powershell -nop -c "& {sleep 30}"
11 changes: 11 additions & 0 deletions Miniforge3/mambaforge_deprecation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/bash

if [[ "$GITHUB_ACTIONS" == "true" ]]; then
echo "::warning title=Mambaforge is now deprecated!::Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience."
else
echo "!!!!!! Mambaforge is now deprecated !!!!!"
echo "Future Miniforge releases will NOT build Mambaforge installers."
echo "We advise you switch to Miniforge at your earliest convenience."
fi
echo "Sleeping for 30s..."
sleep 30
12 changes: 5 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ Latest installers with PyPy 3.9 in the base environment:
| OS X | x86_64 | macOS >= 10.13 | [Miniforge-pypy3-MacOSX-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge-pypy3-MacOSX-x86_64.sh) |
| Windows | x86_64 | Windows >= 7 | [Miniforge-pypy3-Windows-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge-pypy3-Windows-x86_64.exe) |

<details><summary>Mambaforge (Discouraged as of September 2023)</summary>
<details>

<summary>🚨 Mambaforge (<b>Deprecated</b> as of July 2024) 🚨</summary>

With the [release](https://github.com/conda-forge/miniforge/releases/tag/23.3.1-0) of
`Miniforge3-23.3.1-0`, that incorporated the changes in
Expand All @@ -58,12 +60,8 @@ configuration of `Mambaforge` and `Miniforge3` are now **identical**. The
only difference between the two is the name of the installer and, subsequently,
the default installation directory.

Given its wide usage, there are no plans to deprecate Mambaforge. If at some
point we decide to deprecate Mambaforge, it will be appropriately announced and
communicated with sufficient time in advance.

As of September 2023, the new usage of Mambaforge is thus discouraged. Bug
reports specific to Mambaforge will be closed as won't fix.
We recommend switching to `Miniforge3` immediately. These installers will be
retired in January 2025.
beckermr marked this conversation as resolved.
Show resolved Hide resolved

#### Mambaforge

Expand Down
Loading