Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mmcv (v2 version, rename from mmcv-recipe) #22536

Closed
wants to merge 4 commits into from
Closed

Add mmcv (v2 version, rename from mmcv-recipe) #22536

wants to merge 4 commits into from

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 12, 2023 •
edited
Loading

OpenMMLab Computer Vision Foundation. Repo at https://github.com/open-mmlab/mmcv

Note that the mmcv-full package has been renamed to mmcv in version 2.0.0 (see conda-forge/mmcv-recipe-feedstock#19 (comment) and open-mmlab/mmcv#2235). This new mmcv v2 recipe will replace the current v1 recipe at https://github.com/conda-forge/mmcv-recipe-feedstock.

Xref renaming discussion at conda-forge/conda-forge.github.io#1768 (comment) on how the old package (i.e. mmcv-recipe) will need to be archived once the new package (i.e. mmcv) is done.

Supersedes #19400

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@weiji14
Add mmcv
bde64e2 
OpenMMLab Computer Vision Foundation. Repo at https://github.com/open-mmlab/mmcv
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mmcv) and found some lint.

Here's what I've got...

For recipes/mmcv:

  • The recipe license should not include the word "License".
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/mmcv:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mmcv) and found some lint.

Here's what I've got...

For recipes/mmcv:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mmcv) and found it was in an excellent condition.

weiji14
weiji14 commented Apr 12, 2023
View reviewed changes
recipes/mmcv/meta.yaml
Comment on lines +56 to +59
license: Apache-2.0 AND LicenseRef-NVIDIA-License
license_file:
- LICENSE
- LICENSES.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'NVIDIA Licenses' in LICENSES.md seem to be a mix of Nvidia Source Code License-NC and a generic Copyright (c) 2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved. license. Is it ok to just use LicenseRef-NVIDIA-LIcense here?

recipes/mmcv/meta.yaml
Comment on lines +63 to +64
recipe-maintainers:
- weiji14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apatsekin, would you like to be a conda-forge recipe maintainer for mmcv (need a yes/no answer) since you were one for https://github.com/conda-forge/mmcv-recipe-feedstock? This is the mmcv>=2.0 version (because mmcv-full has been renamed to mmcv in v2.0).

Suggested change
recipe-maintainers:
- weiji14
recipe-maintainers:
- apatsekin
- weiji14

@weiji14 weiji14 marked this pull request as ready for review April 13, 2023 19:35
@weiji14
Copy link
Member Author

weiji14 commented Apr 13, 2023 •
edited
Loading

@conda-forge/help-python, ready for review! Would appreciate some help with the NVIDIA license at #22536 (comment) and doublechecking the cuda/pytorch pin_compatible stuff.

@weiji14 weiji14 mentioned this pull request May 1, 2023
Closed
@h-vetinari
Copy link
Member

These outputs should be renamed on the existing feedstock rather than creating a new one.

weiji14 added a commit to regro-cf-autotick-bot/mmcv-recipe-feedstock that referenced this pull request May 15, 2023
@weiji14
Rename from mmcv-full to mmcv and build using pip install . -vv
1debe6e 
Rename package output from mmcv-full to mmcv, and build from the PyPI tar.gz file instead of the GitHub source tar.gz. Cherry-picked from conda-forge/staged-recipes#22536. Also added LICENSE and LICENSE.md files.
@weiji14 weiji14 marked this pull request as draft May 16, 2023 23:22
weiji14 added a commit to conda-forge/mmcv-recipe-feedstock that referenced this pull request May 17, 2023
@regro-cf-autotick-bot @weiji14
mmcv-recipe v2.0.0 (#19)
9e3fb78 
* updated v2.0.0

* Add mmengine to runtime deps

Xref https://github.com/open-mmlab/mmcv/blob/v2.0.0/requirements/runtime.txt

* Rename from mmcv-full to mmcv and build using pip install . -vv

Rename package output from mmcv-full to mmcv, and build from the PyPI tar.gz file instead of the GitHub source tar.gz. Cherry-picked from conda-forge/staged-recipes#22536. Also added LICENSE and LICENSE.md files.

* Use full url to mmcv package on PyPI

Without the {{ name }} variable.

* Partial revert to old build script

Going from PyPI back to the GitHub source.

* MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and conda-forge-pinning 2023.05.16.03.36.14

* Add .dev_scripts/test_installation.py to source_files

Also fix some whitespaces to reduce git diff

* Trim down cuda_compiler_version if-then to just 11.2

Xref conda-forge/conda-forge.github.io#1901.

* Add onnx, torchvision, pyturbojpeg to test.requires

* Add tifffile

* Add numpy to build requirements

See if it fixes `ImportError: cannot import name '_fastCopyAndTranspose' from 'numpy.core._multiarray_umath' (/Users/runner/miniforge3/conda-bld/mmcv-recipe_1684234509266/_build_env/venv/lib/python3.10/site-packages/numpy/core/_multiarray_umath.cpython-310-darwin.so)`

* Add back pytorch(-cpu) to build dependencies

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: conda-forge-webservices[bot] <91080706+conda-forge-webservices[bot]@users.noreply.github.com>
@weiji14
Copy link
Member Author

weiji14 commented May 17, 2023

These outputs should be renamed on the existing feedstock rather than creating a new one.

Ok, package renamed at conda-forge/mmcv-recipe-feedstock#19. New mmcv=2.0.0 packages now up at https://anaconda.org/conda-forge/mmcv/files.

@weiji14 weiji14 closed this May 17, 2023
@weiji14 weiji14 deleted the mmcv branch May 17, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @h-vetinari