Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yes no parsing #664

Merged
merged 10 commits into from
May 12, 2023
Merged

Fix yes no parsing #664

merged 10 commits into from
May 12, 2023

Conversation

marcoesters
Copy link
Contributor

@marcoesters marcoesters commented Apr 26, 2023

Description

Improve yes/no parsing for interactive installation with sh installers.

  • Make answers case insensitive
  • Accept default value for license agreement question

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @marcoesters.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@marcoesters marcoesters marked this pull request as ready for review April 26, 2023 18:36
@marcoesters marcoesters requested a review from a team as a code owner April 26, 2023 18:36
Copy link
Contributor

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built an example MinicondaX using @marcoesters's dev branch, and the default [no] now gets applied when I hit Enter, and the installer exits as expected.

Screen Shot 2023-05-03 at 4 28 26 PM copy

I noticed two of the CI builds are failing on the example builds, but it's not clear what the causes are (here and here). Perhaps they just need a re-punch?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 11, 2023
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this code appear so often in the installer makes me wonder whether we should put it in a function, but that can be done in a different PR.

Thanks!

@jaimergp jaimergp merged commit 66e691b into main May 12, 2023
@jaimergp jaimergp deleted the fix-yes-no-parsing branch May 12, 2023 09:44
@jaimergp jaimergp mentioned this pull request Jun 19, 2023
31 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants