Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve standalone executable type detection and handling #864

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

marcoesters
Copy link
Contributor

Description

This PR implements several improvements for how constructor detects and handles which kind of standalone (conda-standalone, micromamba, etc.) executable is used:

  • Replace string comparisons with enums for the executable types.
  • Use the result of identify_conda_exe everywhere instead of using the file name.
  • Explicitly identify mamba-type executables.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 20, 2024
@marcoesters marcoesters marked this pull request as ready for review September 20, 2024 19:21
@marcoesters marcoesters requested a review from a team as a code owner September 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants