Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tg4-group contract #105

Merged
merged 14 commits into from
Feb 16, 2022
Merged

Add tg4-group contract #105

merged 14 commits into from
Feb 16, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Feb 16, 2022

Based on cw4-group. Adapted to tgrade-bindings (TgradeMsg), and tgrade-utils hooks.

Publishing as Draft, as tests are still failing. (fixed)

@maurolacy maurolacy marked this pull request as ready for review February 16, 2022 08:35
Copy link

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

contracts/tg4-group/Cargo.toml Outdated Show resolved Hide resolved
contracts/tg4-group/Cargo.toml Outdated Show resolved Hide resolved
@@ -0,0 +1,606 @@
use crate::ContractError::Unauthorized;
Copy link

@ueco-jb ueco-jb Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this file/contract is mostly copied from cw-plus with s/weight/points renamed?

Copy link
Contributor Author

@maurolacy maurolacy Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That, plus introducing the TgradeMsg binding. Plus adapting the hooks to tg-utils (based on the tg4-engagement impl)

maurolacy and others added 2 commits February 16, 2022 09:55
Co-authored-by: Jakub Bogucki <jakub@confio.gmbh>
Co-authored-by: Jakub Bogucki <jakub@confio.gmbh>
@maurolacy maurolacy merged commit 98e96c0 into main Feb 16, 2022
@maurolacy maurolacy deleted the tg4-group branch February 16, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants