Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.3 release #19

Merged
merged 4 commits into from
Jan 13, 2022
Merged

0.5.3 release #19

merged 4 commits into from
Jan 13, 2022

Conversation

maurolacy
Copy link
Contributor

Closes #13.

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Before tagging, we need to set up the GITHUB_TOKEN in the CI so it will publish the build artefacts (wasm) automatically.

@maurolacy
Copy link
Contributor Author

maurolacy commented Jan 13, 2022

Before tagging, we need to set up the GITHUB_TOKEN in the CI so it will publish the build artefacts (wasm) automatically.

Will try to do it, and ask you in any case.

Update: Done. Followed this: https://circleci.com/blog/publishing-to-github-releases-via-circleci/ and created a Personal Access Token with repo:status, repo:deployment, repo:public_repo and read:repo_hook permissions.

Update2: Had to add the workflow, admin:org and admin:org_hook to make the release artifacts publication work. This is probably because this repo is still private. We can use a more restrictive token once this is public.

@ethanfrey
Copy link
Contributor

One more issue popped up, can it be squeezed in?
https://github.com/confio/tgrade-contracts/issues/438

@maurolacy maurolacy merged commit 26fecab into main Jan 13, 2022
@maurolacy maurolacy deleted the 0.5.3-release branch January 13, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag poe-contracts v0.5.3
3 participants