Moved PoE contracts: engagement, mixer, stake, valset #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic PoE contracts moved.
I am pretty sure that those contracts are to be moved. I am also pretty sure, that gov-reflect, validator-voting are also to be moved, but I am not 100% sure, so I don't want to move them unless confirmed to not publish code which should be closed source. If you have second thoughts about if particular contract should be moved, please note it here - it is easier to cut off entire not merged branch from repo history, that code which was already merged.
In terms of packages - only those required for moved contracts to work are moved (bindings with tests, tg4, utils).
I know the review is huge, but I don't expect detailed review. What i did is just moved the whole contracts and packages as they are, and made sure that all packages are required (by removing them one by one checking if contracts compile). Nothing more. Double checking README might be useful (I went through them to remove links to tgrade issues). Only thing which was chaged from actual tgrade repo is CI config (stripped from not used parts). Reviewing the implementation of contract itself would be prob waste of time.