Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valset: Add a feature to update min_weight and max_validators #45

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Jan 26, 2022

Closes #28

Two ways to update min_weight and max_validators - by migration or by using an ExecuteMsg entrypoint.

@uint
Copy link
Contributor Author

uint commented Jan 27, 2022

Rebased to fix CI problems.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maurolacy maurolacy merged commit d2e5dd1 into main Jan 27, 2022
@maurolacy maurolacy deleted the 28-update-max-validators branch January 27, 2022 11:45
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

min_weight: Option<u64>,
max_validators: Option<u32>,
) -> Result<Response, ContractError> {
ADMIN.assert_admin(deps.as_ref(), &info.sender)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good this is checked.

maurolacy added a commit that referenced this pull request Jan 27, 2022
valset: Add a feature to update `min_weight` and `max_validators`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valset: update max_validators
3 participants