Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain to v1.58.1 #58

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Update rust toolchain to v1.58.1 #58

merged 2 commits into from
Jan 31, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Jan 31, 2022

@uint uint mentioned this pull request Jan 31, 2022
Merged
@maurolacy
Copy link
Contributor

This works, but why not take the opportunity and upload all CI workflows to work with current stable (v1.58.1)?

@uint
Copy link
Contributor Author

uint commented Jan 31, 2022

This works, but why not take the opportunity and upload all CI workflows to work with current stable (v1.58.1)?

I guess I wanted to be cautious. Sure, will do.

@uint uint changed the title Update rust toolchain to v1.56.1 Update rust toolchain to v1.58.1 Jan 31, 2022
@ethanfrey
Copy link
Contributor

We generally try to keep this behind for a bit, as whatever the CI says is the "lowest supported version". We don't need to make cosmwasm devs update every few weeks.

However, I guess when we do update, everyone has to update, so maybe we do jump a bit? We should record lowest supported version in the README (and match cw-plus if possible)

@maurolacy
Copy link
Contributor

cw-plus is already working with 1.58.1. The next rust-optimizer will ship with this version as well, so, good to move to it.

maurolacy
maurolacy approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maurolacy maurolacy merged commit b51f308 into main Jan 31, 2022
@maurolacy maurolacy deleted the rust-1.56.1 branch January 31, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

@hashedone hashedone Awaiting requested review from hashedone

@ueco-jb ueco-jb Awaiting requested review from ueco-jb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uint @maurolacy @ethanfrey