Add support for graceful shutdown in fastify #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Sep 29, 2023
| setTimeout(() => { | ||
| shutdownController.abort(opts.shutdownError); | ||
| }, opts.shutdownTimeoutMs); | ||
| done(); |
There was a problem hiding this comment.
Shouldn't done be called after the grace period? So in the setTimeout callback?
There was a problem hiding this comment.
Either should be fine, Fastify waits for the requests to finish even there are no preClosehooks.
timostamm
approved these changes
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #802.
Once
Fastify.closeis called it waits for requests to complete and immediately blocks new ones. We use thepreClosehook, which is called right whencloseis called, to start a shutdown timeout for requests and close them if the time runs out.The other option is just to document this so that users can set the
shutdownSignalas we do in this PR.