Fix missing implicit types #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to bundle up the generated code with `tsc --declaration=true`, ts couldn't figure out the disableQuery type and the BaseInfiniteQueryOptions. This is able to be resolved if the exported querys are explicitly typed
|
|
timostamm
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Hey Greg, I believe this is the correct fix, thanks for the contribution!
We did the same in protobuf-es in bufbuild/protobuf-es#398.
I'll defer to @paul-sachs regarding any implementation details.
paul-sachs
reviewed
Oct 6, 2023
| @@ -74,13 +75,22 @@ const generateServiceFile = | |||
| ); | |||
| f.print(); | |||
|
|
|||
|
|
|||
| const unaryFunctionType = (method: DescMethod) => [f.import('UnaryFunctions', '@connectrpc/connect-query'), `<${method.input.name}, ${method.output.name}>`] | |||
There was a problem hiding this comment.
@mckelveygreg This looks good, though I think we can simplify by using the helper type UnaryFunctionsWithHooks instead of UnaryFunctions<...> & UnaryHooks<...>.
There was a problem hiding this comment.
😅 Ha, yeah that is much more straight forward!
Thanks!
paul-sachs
approved these changes
Oct 6, 2023
Merged
paul-sachs
added a commit
that referenced
this pull request
Oct 6, 2023
## What's Changed * Remove experimental plugin by @paul-sachs in #178 * Add ESM wrapper to avoid dual package hazard by @timostamm in #180 * Fix missing implicit types by @mckelveygreg in #211 ## New Contributors * @mckelveygreg made their first contribution in #211 **Full Changelog**: v0.5.1...v0.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have really appreciated this lib, and have been using it since it came out! I think I found a typing fix to make it even more usable.
When trying to bundle up the generated code with
tsc --declaration=true, ts couldn't figure out thedisableQuerytype and theBaseInfiniteQueryOptionstype. This is able to be resolved if the exported queries are explicitly typed.This also will resolve #209 🎉
Let me know if there is anything else I can do to this PR!