Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin version unknown (1.4.1 release) #1019

Closed
tristanmorgan opened this issue Mar 13, 2024 · 8 comments · Fixed by #1037
Closed

plugin version unknown (1.4.1 release) #1019

tristanmorgan opened this issue Mar 13, 2024 · 8 comments · Fixed by #1037
Assignees

Comments

@tristanmorgan
Copy link

Hi, The latest builds (1.4.1) of the CNI plugins are not printing the plugin versions when run.
I've tested both x86_64 and Arm64 packages. I suspect changes in the build process since 1.4.0 release missed setting BuildVersion.

# /opt/cni/bin/dummy 
CNI dummy plugin version unknown
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0
@maxadamo
Copy link

maxadamo commented Apr 28, 2024

This is going to create problems to other tools: https://github.com/GEANT/nomad_cni/blob/main/lib/facter/nomad_cni_version.rb#L10

I hope you could delete and reissue this version.

@FibreFoX
Copy link

Or just release 1.4.2 instead of re-publishing, maybe to address #1033 too

@antoninbas
Copy link

+1
This script is no longer used for releases: https://github.com/containernetworking/plugins/blob/main/scripts/release.sh
As a result, github.com/containernetworking/plugins/pkg/utils/buildversion.BuildVersion is no longer set using linker flags.

@squeed
Copy link
Member

squeed commented May 14, 2024

@s1061123 can you take a look? I know you worked on automated release building.

@squeed
Copy link
Member

squeed commented May 14, 2024

In the mean time, I'll re-build the release with the version set properly.

@squeed
Copy link
Member

squeed commented May 14, 2024

Rebuilt the release, PTAL

@s1061123
Copy link
Contributor

@squeed I got that script misses build version (ldflags in release.sh script). Will fix that soon.

s1061123 added a commit to s1061123/plugins that referenced this issue May 14, 2024
This changes adds BuildVersion linker flag in release to
fix CNI plugins output. Fixes containernetworking#1019.

Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
@s1061123
Copy link
Contributor

@squeed #1037 fixes the issue. PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants