Skip to content

Commit

Permalink
Add FIXMEs
Browse files Browse the repository at this point in the history
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
  • Loading branch information
mtrmac committed Aug 4, 2023
1 parent 3c759f9 commit 7eeed2c
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions internal/image/oci_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,8 @@ func TestManifestOCI1ConvertToManifestSchema1(t *testing.T) {
var expected manifest.NonImageArtifactError
assert.ErrorAs(t, err, &expected)

// FIXME: Test that conversion of an encrypted image fails

// Conversion to schema1 with encryption fails
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt),
Expand All @@ -507,6 +509,8 @@ func TestManifestOCI1ConvertToManifestSchema1(t *testing.T) {
})
assert.Error(t, err)

// FIXME: Test that conversion with decryption is possible (make it work first)

// FIXME? Test also the other failure cases, if only to see that we don't crash?
}

Expand Down Expand Up @@ -535,13 +539,17 @@ func TestConvertToManifestSchema2(t *testing.T) {
var expected manifest.NonImageArtifactError
assert.ErrorAs(t, err, &expected)

// FIXME: Test that conversion of an encrypted image fails

// Conversion to schema2 with encryption fails
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt),
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
assert.Error(t, err)

// FIXME: Test that conversion with decryption is possible (make it work first)

// FIXME? Test also the other failure cases, if only to see that we don't crash?
}

Expand Down

0 comments on commit 7eeed2c

Please sign in to comment.