Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote the response body in an error message #2186

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 13, 2023

... to make sure we don't output raw control characters, for example.

A probably unexpected outcome of containers/podman#20343 .

@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2023

LGTM
@vrothberg PTAL

@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Nov 13, 2023
... to make sure we don't output raw control characters, for example.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 96eab26 into containers:main Nov 14, 2023
9 checks passed
@mtrmac mtrmac deleted the quote-response-body branch November 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants