Add a helper for formatting multiple errors #2365
Merged
Commits on Apr 3, 2024
-
Introduce internal/multierr.Format
It's sad that this is even necessary, but using fmt.Errorf with an []error is way too inconvenient without a helper. Only adds a new function, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
-
Use multierr.Format where possible
This may make errors visible to errors.As/errors.Is This commit, in general, attempts not to change the formatting; only in newShortNameAliasCache, the order of the errors is no longer reversed. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
-
Improve the error formatting in newShortNameAliasCache
Don't treat the first error specially. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
-
Remove the (direct) dependency on github.com/hashicorp/go-multierror
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.