cleanup: nuke unused scripts, Makefile bits and defunct functionality. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/build/docker-build-image is unused. Let's remove it. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove page-migration controller and controls. Some of the necessary infra has not been fully enabled over the transition away from a CRI proxy and the functionality has been anyway obsoleted by memtierd. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove defunct memory controller. It is mostly obsolete and the necessary related kernel controls have never been upstreamed, Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove the unused introspection interface. It was originally used by the policy and workload placement visualization proto which we have already removed earlier. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove rebalancing policy interface and the related resmgr bits (timer, event). In its current form it was non-functional anyway with the timer and rebalance-triggering event disabled in resmgr. Most policies did not implement rebalancing either. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
|
I'm worried about rebalance infra of code. Probably need to make a backlog item to redesign it to work as expected in NRI scope. |
I think it's best to nuke the unused/untested code. Create a new GitHub issue about enabling it we want it back. EDIT: we still have the code in git history 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set nukes