Update to Go 1.20 #2252
Merged
Update to Go 1.20 #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed. v1.15.0 fails to compile with go 1.19. |
felipecrs
added a commit
to felipecrs/skopeo-bin
that referenced
this pull request
Mar 15, 2024
Also adds some basic tests to ensure that the built binary is ok. Refs containers/skopeo#2252
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
|
LGTM |
|
golang 1.20 is fine, it's 1.21 we need to be careful with. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After containers/image#2337 (notably go-openapi/swag@v0.22.10...v0.23.0 ), c/image will require Go 1.20 to build.
This does not yet update to that version of c/image, but that will happen soon enough.
So, update to Go 1.20, and take advantage of new standard library features.