Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to the CLA.md cannot be used as variable in custom custom-notsigned-prcomment #113

Open
simonmeggle opened this issue Aug 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@simonmeggle
Copy link
Contributor

Describe the bug
It is not possible to link to the CLA document if you use a custom custom-notsigned-prcomment in cla.yml.

To Reproduce
Add this line to cla.yml:

custom-notsigned-prcomment: '<br/>Thank you for your Pull Request, we really appreciate it!<br/>We kindly ask that you to sign our [Contributor License Agreement](${input.getPathToDocument()}) before....  ... .... '

But obviously, getPathToDocument cannot be called within a custom message.

Expected behavior
I expect to see the Hyperlink to the documentation.

=> How can I use a custom custom-notsigned-prcomment and still insert the CLA link dynamically?

@simonmeggle simonmeggle added the bug Something isn't working label Aug 25, 2022
@simonmeggle simonmeggle changed the title Usage of Path to the CLA.md cannot be used as variable in custom-notsigned-prcomment Aug 29, 2022
@simonmeggle simonmeggle changed the title Path to the CLA.md cannot be used as variable in custom-notsigned-prcomment Path to the CLA.md cannot be used as variable in custom custom-notsigned-prcomment Aug 29, 2022
furkansahin added a commit to ubicloud/ubicloud that referenced this issue Feb 15, 2024
It looks like using custom messages fails the link usage to the CLA. The
issue can be found here
contributor-assistant/github-action#113.
furkansahin added a commit to ubicloud/ubicloud that referenced this issue Feb 15, 2024
It looks like using custom messages fails the link usage to the CLA. The
issue can be found here
contributor-assistant/github-action#113.
@ronald-jaepel
Copy link

ronald-jaepel commented Jun 24, 2024

edit: Sorry for the necro. Didn't check the dates.

Hey,

we got this working by turning it into an environment variable.
The following works for us:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  [...]
  PATH_TO_CLA: 'https://github.com/.../.../main/CLA.md'
with:
  path-to-signatures: [...]
  path-to-document: $PATH_TO_CLA
  [...]
  custom-notsigned-prcomment: >
      Like many open-source projects we ask that you sign our [Contributor License Agreement]($PATH_TO_CLA) before we can accept your contribution.
  [...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants