Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci ci-setup.md #3989

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

HennaAbbas
Copy link
Contributor

@HennaAbbas HennaAbbas commented Mar 20, 2024

The syntax of the circleci config.yml was out of date.

Description

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The syntax of the circleci config.yml was out of date.
Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Hey @HennaAbbas thanks for this. Would you mind fixing the failing linting check? I can also help with that.

@knocte
Copy link
Contributor

knocte commented Apr 8, 2024

How can a change to an .md file cause a CI failure?

@escapedcat
Copy link
Member

How can a change to an .md file cause a CI failure?

I guess prettier isn't happy with it. Will fix it.

@escapedcat
Copy link
Member

Locally it's not failing, yay?!... Let's re-trigger

@escapedcat
Copy link
Member

Still failing, I don't understand why

@knocte
Copy link
Contributor

knocte commented Apr 8, 2024

The prettier step needs better output, maybe print in CI log what git diff outputs?

@escapedcat escapedcat merged commit 398be5a into conventional-changelog:master Apr 8, 2024
7 checks passed
@escapedcat
Copy link
Member

Looks like it was some sort of caching issue locally, weird.

Thanks @HennaAbbas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants