Implement Theme as a Trait #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conways-glider
added a commit
that referenced
this pull request
Aug 1, 2024
* Use a trait instead of an enum * Update documentation * Run cargo fmt * Clean up test * Rename `Themey` to `Theme` * Add identicon methods around theme
conways-glider
added a commit
that referenced
this pull request
Aug 20, 2024
* Add basic theming objects * Convert to using theme object * Clean up comments and fix tests. The fact that the consistency test had to change means that we will have to consider this feature a breaking change and thus a major version bump. * Update map and bitshift logic * Move theme to folder module instead of file * Run cargo fmt * Move file yet again * Implement Theme as a Trait (#43) * Use a trait instead of an enum * Update documentation * Run cargo fmt * Clean up test * Rename `Themey` to `Theme` * Add identicon methods around theme * Run cargo fmt * Test on all features * Fix matrix * Move color structs to their own module * Change Theme trait to return Result<> (#45) * Change Theme trait to return results * Add ThemeError * Update testing * Add default feature * Use Arc<> * Run cargo clippy on tests * Test consistency of themes * Clean up tests * Add lints around unwrap and expect * Add constructors for themes * Run cargo fmt * Add theme example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.