Add button dropdown for switching graph / timeline

Signed-off-by: Patrick Coray <patrick.coray@bluewin.ch>
copa2 · Nov 18, 2018 · 09dafb4 · 09dafb4
1 parent 7a8a730
commit 09dafb4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader.css b/packages/jaeger-ui/src/components/TracePage/TracePageHeader.css
@@ -17,6 +17,7 @@ limitations under the License.
 .TracePageHeader--titleRow {
   align-items: center;
   display: flex;
+  padding-right: 0.5rem;
 }
 
 .TracePageHeader--title {

diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js b/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js
@@ -15,7 +15,7 @@
 // limitations under the License.
 
 import * as React from 'react';
-import { Button, Dropdown, Icon, Input, Menu } from 'antd';
+import { Button, Dropdown, Input, Menu } from 'antd';
 import IoChevronDown from 'react-icons/lib/io/chevron-down';
 import IoChevronRight from 'react-icons/lib/io/chevron-right';
 import IoIosFilingOutline from 'react-icons/lib/io/ios-filing-outline';
@@ -143,9 +143,6 @@ export function TracePageHeaderFn(props: TracePageHeaderProps) {
           Trace JSON (unadjusted)
         </Link>
       </Menu.Item>
-      <Menu.Item>
-        <a onClick={onTraceGraphViewClicked}>{traceGraphView ? 'Trace Timeline' : 'Trace Graph'}</a>
-      </Menu.Item>
     </Menu>
   );
 
@@ -196,11 +193,9 @@ export function TracePageHeaderFn(props: TracePageHeaderProps) {
           resultCount={resultCount}
           ref={forwardedRef}
         />
-        <Dropdown overlay={viewMenu}>
-          <Button className="ub-mr2">
-            View Options <Icon type="down" />
-          </Button>
-        </Dropdown>
+        <Dropdown.Button overlay={viewMenu} onClick={onTraceGraphViewClicked}>
+          {traceGraphView ? 'Trace Timeline' : 'Trace Graph'}
+        </Dropdown.Button>
         {archiveButtonVisible && (
           <Button className="ub-mr2 ub-flex ub-items-center" onClick={onArchiveClicked}>
             <IoIosFilingOutline className="TracePageHeader--archiveIcon" />