Skip to content

Commit

Permalink
update all remaining build actions for GHA
Browse files Browse the repository at this point in the history
also remove debug testing action from `build-and-test.yml`
  • Loading branch information
nick-funk committed May 30, 2024
1 parent 302e39b commit 5cef7d1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
15 changes: 2 additions & 13 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,9 @@ jobs:
run: sh scripts/build.sh
- name: Verify Bundle Size
run: cd client && ./node_modules/.bin/bundlesize --enable-github-checks
# Debugging
- name: Build, Tag, Push (Debug)
uses: docker/build-push-action@v5
if: github.ref == 'refs/heads/fix/build-tag-push'
with:
push: true
tags: ${{ env.IMAGE_REPOSITORY }}:debug-test
build-args: |
REVISION_HASH=${GITHUB_SHA}
cache-from: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-debug
cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-debug
# Build tag push the image after a merge to develop
- name: Build, Tag, Push
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
if: github.ref == 'refs/heads/develop'
with:
push: true
Expand All @@ -107,7 +96,7 @@ jobs:
cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-develop
# Build tag push the release candidate image when the branch name begins with release-
- name: Build, Tag, Push RC
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
if: startsWith( github.ref, 'refs/heads/release-')
with:
push: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ secrets.REPO_PATCHED_DEPLOY_KEY }}
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
echo "MINOR_TAG=${MAJOR}.${MINOR}" >> $GITHUB_ENV
echo "PATCH_TAG=${MAJOR}.${MINOR}.${PATCH}" >> $GITHUB_ENV
- name: Build, Tag, Push Major Tag
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
push: true
tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MAJOR_TAG }}
Expand All @@ -107,7 +107,7 @@ jobs:
cache-from: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
- name: Build, Tag, Push Minor Tag
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
push: true
tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MINOR_TAG }}
Expand Down

0 comments on commit 5cef7d1

Please sign in to comment.