dont use null in maybeValue

fix type error in stacks
coralproject · Jun 22, 2023 · f8b66b9 · f8b66b9
1 parent 6bdd0c4
commit f8b66b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/codegen.yml b/codegen.yml
@@ -21,7 +21,7 @@ generates:
       avoidOptionals:
         inputValue: true
       customResolverFn: "(parent: TParent, args: TArgs, ctx: TContext, info: GraphQLResolveInfo) => ResolverTypeWrapper<any>"
-      maybeValue: "T | null | undefined"
+      maybeValue: "T | undefined"
       useInstanceSignature: true
       scalars: # TODO: check that this is indeed true
         ID:

diff --git a/src/core/server/stacks/helpers/updateAllCommentCounts.ts b/src/core/server/stacks/helpers/updateAllCommentCounts.ts
@@ -115,7 +115,10 @@ export const calculateTags = (
   };
 
   let total = 0;
-  for (const [, value] of Object.entries(tags)) {
+  const values = Object.values(tags).filter(
+    (v) => typeof v !== "number"
+  ) as number[];
+  for (const value of values) {
     total += value;
   }