Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2856] Single site ban options #4285

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

marcushaddon
Copy link
Contributor

What does this PR do?

This PR addresses a bug in which options specific to multi site tenenants were displayed for single site tenants when managing a user's ban status.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None.

Does this PR introduce any new environment variables or feature flags?

No.

If any indexes were added, were they added to INDEXES.md?

n/a
-->

How do I test this PR?

On a single site tenant, as a user with ban management privileges, navigate to the community page, and click to manage a user's ban status. Observe that no radio buttons related to "All sites", "Specific sites" or "No sites" are displayed.

Where any tests migrated to React Testing Library?

No.

How do we deploy this PR?

No special considerations should be required

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit e31d4ef
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/64ad949a7dedd9000880ca50

@marcushaddon marcushaddon marked this pull request as ready for review July 5, 2023 18:37
Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small comments.

src/core/client/admin/test/community/banUser.spec.tsx Outdated Show resolved Hide resolved
src/core/client/admin/test/community/banUser.spec.tsx Outdated Show resolved Hide resolved
src/core/client/admin/test/community/banUser.spec.tsx Outdated Show resolved Hide resolved
@tessalt tessalt added this to the v8.4.1 milestone Jul 11, 2023
@tessalt tessalt added this pull request to the merge queue Jul 24, 2023
Merged via the queue into develop with commit 659a77e Jul 24, 2023
7 checks passed
@tessalt tessalt deleted the fix/CORL-2853-single-site-options-2 branch July 24, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants