Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build-tag-push step in GitHub Actions #4627

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix build-tag-push step in GitHub Actions #4627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db5b5fe
test build-tag-push with latest build-push-action@v5
nick-funk May 30, 2024
978ecbe
set `setup-buildx-action` to v3
nick-funk May 30, 2024
302e39b
add python pip and setuptools to docker image
nick-funk May 30, 2024
5cef7d1
update all remaining build actions for GHA
nick-funk May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ secrets.REPO_PATCHED_DEPLOY_KEY }}
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
run: cd client && ./node_modules/.bin/bundlesize --enable-github-checks
# Build tag push the image after a merge to develop
- name: Build, Tag, Push
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
if: github.ref == 'refs/heads/develop'
with:
push: true
Expand All @@ -96,7 +96,7 @@ jobs:
cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-develop
# Build tag push the release candidate image when the branch name begins with release-
- name: Build, Tag, Push RC
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
if: startsWith( github.ref, 'refs/heads/release-')
with:
push: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ secrets.REPO_PATCHED_DEPLOY_KEY }}
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
echo "MINOR_TAG=${MAJOR}.${MINOR}" >> $GITHUB_ENV
echo "PATCH_TAG=${MAJOR}.${MINOR}.${PATCH}" >> $GITHUB_ENV
- name: Build, Tag, Push Major Tag
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
push: true
tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MAJOR_TAG }}
Expand All @@ -107,7 +107,7 @@ jobs:
cache-from: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
- name: Build, Tag, Push Minor Tag
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
push: true
tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MINOR_TAG }}
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM node:18-alpine
ENV NODE_OPTIONS="--max-old-space-size=8192 --openssl-legacy-provider --no-experimental-fetch"

# Install build dependancies.
RUN apk --no-cache --update add g++ make git python3 \
RUN apk --no-cache --update add g++ make git python3 py3-pip py3-setuptools \
&& rm -rf /var/cache/apk/*

RUN npm install -g pnpm@8.14.3
Expand Down
Loading